Page MenuHomeSolus

The inclusion of onionshare-cli fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 10:01 PM.
Tags
None
Referenced Files
F10871035: D12765.diff
Jun 18 2023, 12:53 PM
F10804441: D12765.id31138.diff
May 29 2023, 4:08 PM
F10804312: D12765.id31709.diff
May 29 2023, 3:35 PM
F10804254: D12765.id31081.diff
May 29 2023, 3:17 PM
F10804136: D12765.id31105.diff
May 29 2023, 2:52 PM
F10804013: D12765.id31746.diff
May 29 2023, 2:27 PM
F10803755: D12765.id31083.diff
May 29 2023, 1:15 PM
F10801967: D12765.diff
May 29 2023, 4:49 AM
Subscribers

Details

Summary

Used from onionshare

Depends on D12758
Depends on D12759
Depends on D12761
Depends on D12763

Test Plan

Execute tests

Diff Detail

Repository
R5474 onionshare-cli
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

maikwoehl retitled this revision from The inclusion of onionshare-cli will fix T10009 to The inclusion of onionshare-cli fixes T10009.Jan 23 2022, 10:22 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
4

this should be 1

This revision now requires changes to proceed.Jan 24 2022, 10:37 AM

Adding tests and repairing release version

This revision is now accepted and ready to land.Jan 26 2022, 8:40 AM

Small changes needed here. You can remove python-pysocks and python-urllib3 from builddeps and rundeps because they are pulled by other packages.
And remember about renaming flask-socketio.

algent requested changes to this revision.Jan 26 2022, 12:27 PM
This revision now requires changes to proceed.Jan 26 2022, 12:27 PM
This revision is now accepted and ready to land.Jan 28 2022, 8:51 AM

the soruce download fails now, can you have a look?

This revision now requires changes to proceed.Feb 20 2022, 11:13 AM

That is because 11.0.4 tarball was removed. He can try 11.0.6 instead:
https://dist.torproject.org/torbrowser/11.0.6/tor-browser-linux64-11.0.6_en-US.tar.xz : dfb1d238e2bf19002f2f141178c3af80775dd8d5d83b53b0ab86910ec4a1830d

and change this too:
cp -v $sources/tor-browser-linux64-11.0.6_en-US.tar.xz desktop/build/tor

EDIT: Not sure why it still fails.

It was failing because this script was looking for version 11.0.4

build      : |
    python3 desktop/scripts/get-tor-linux.py

With this patch it built fine

From 633108ddbe7a9f2e30e411ead6b68cfcfc67b6d1 Mon Sep 17 00:00:00 2001
From: Algent Albrahimi <algent@protonmail.com>
Date: Sun, 20 Feb 2022 14:22:14 +0100
Subject: [PATCH] use version 11.0.6

---
 desktop/scripts/get-tor-linux.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/desktop/scripts/get-tor-linux.py b/desktop/scripts/get-tor-linux.py
index 2882a59..3e5643d 100755
--- a/desktop/scripts/get-tor-linux.py
+++ b/desktop/scripts/get-tor-linux.py
@@ -35,10 +35,10 @@ from bridges import UpdateTorBridges
 
 
 def main():
-    tarball_url = "https://dist.torproject.org/torbrowser/11.0.4/tor-browser-linux64-11.0.4_en-US.tar.xz"
-    tarball_filename = "tor-browser-linux64-11.0.4_en-US.tar.xz"
+    tarball_url = "https://dist.torproject.org/torbrowser/11.0.6/tor-browser-linux64-11.0.6_en-US.tar.xz"
+    tarball_filename = "tor-browser-linux64-11.0.6_en-US.tar.xz"
     expected_tarball_sha256 = (
-        "05a5fd6d633ca84c33bbd3e2f8ffca2d2fa2105032a430b07d3c0cf062d9e15f"
+        "dfb1d238e2bf19002f2f141178c3af80775dd8d5d83b53b0ab86910ec4a1830d"
     )
 
     # Build paths
-- 
2.35.1

@maikwoehl you have to test this again.

Thank you for your help. :)

I was busy with other stuff in the last weeks...

Is on the todo list for the next days!

Patching tor version

tested cli with pytest and some cli commands

This revision is now accepted and ready to land.Mar 6 2022, 8:10 PM
This revision was automatically updated to reflect the committed changes.