Page MenuHomeSolus

The inclusion of python-qrcode fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 9:58 PM.

Details

Summary

Used from onionshare

Test Plan

Use onionshare and execute tests

Diff Detail

Repository
R2676 python-qrcode
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:58 PM
maikwoehl requested review of this revision.Jan 23 2022, 9:58 PM
maikwoehl retitled this revision from The inclusion of python-qrcode will fix T10009 to The inclusion of python-qrcode fixes T10009.Jan 23 2022, 10:21 PM
Girtablulu requested changes to this revision.Jan 24 2022, 10:24 AM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
23

Is it possible to use python_test? I don't like having networking active just for the tests

This revision now requires changes to proceed.Jan 24 2022, 10:24 AM
algent added a subscriber: algent.Jan 24 2022, 10:55 AM

networking : yes, git and python-tox can be removed.
do check with %python3_test pytest3

networking : yes, git and python-tox can be removed.
do check with %python3_test pytest3

You are a magician! Just realized this line in ypkg.

maikwoehl updated this revision to Diff 31097.Jan 24 2022, 8:09 PM

Using pytest3 instead of tox

maikwoehl marked an inline comment as done.Jan 24 2022, 8:10 PM
Girtablulu accepted this revision.Jan 24 2022, 9:16 PM

LGTM, thx

This revision is now accepted and ready to land.Jan 24 2022, 9:16 PM
algent removed a subscriber: algent.Jan 28 2022, 9:02 AM
Girtablulu requested changes to this revision.Feb 2 2022, 8:31 AM

uff wanted to land your stack and got an error, and I saw this https://dev.getsol.us/source/python-qrcode, I reactivated this repo, so you can update this existing repo.

Additionally we need an undepraction of this package in https://github.com/getsolus/solus-sc/ so this gets removed https://github.com/getsolus/solus-sc/blob/master/repo_data/distribution.xml.in#L1293, if you need help regarding this you can ask anyone inside #solus-dev

sorry that I haven't seen it in the beginning

This revision now requires changes to proceed.Feb 2 2022, 8:31 AM
maikwoehl updated this revision to Diff 31237.Feb 2 2022, 5:24 PM

Update package.yml to incorporate existing repository

Girtablulu accepted this revision.Feb 13 2022, 1:17 PM

LGTM, thx

This revision is now accepted and ready to land.Feb 13 2022, 1:17 PM
This revision was automatically updated to reflect the committed changes.