Page MenuHomeSolus

The inclusion of python-gevent fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 9:55 PM.

Details

Summary

Used from onionshare-cli > python-gevent-websocket > python-gevent
Depends on D12760

Test Plan

Use onionshare and execute tests

Diff Detail

Repository
R5472 python-gevent
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:55 PM
maikwoehl requested review of this revision.Jan 23 2022, 9:55 PM
maikwoehl edited the test plan for this revision. (Show Details)Jan 23 2022, 10:05 PM
maikwoehl retitled this revision from The inclusion of python-gevent will fix T10009 to The inclusion of python-gevent fixes T10009.Jan 23 2022, 10:22 PM
algent requested changes to this revision.Jan 24 2022, 12:55 PM
algent added a subscriber: algent.

python-gevent requires newer python-greenlet version:

ERROR: Could not find a version that satisfies the requirement greenlet<2.0,>=1.1.0 (from versions: none)
ERROR: No matching distribution found for greenlet<2.0,>=1.1.0
This revision now requires changes to proceed.Jan 24 2022, 12:55 PM

python-gevent requires newer python-greenlet version:

ERROR: Could not find a version that satisfies the requirement greenlet<2.0,>=1.1.0 (from versions: none)
ERROR: No matching distribution found for greenlet<2.0,>=1.1.0

Oh thank you for your hint.

I'm currently testing with python-greenlet 1.1.2 and have tested pynvim for compatibility. That ignored test is running locally but not in solbuild environment.

mwoehl@dev-solus ~/dev/github/pynvim $ pytest3 -v -k 'not test_invalid_utf8'
==================================================================== test session starts ====================================================================
platform linux -- Python 3.9.9, pytest-4.6.11, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/mwoehl/dev/github/pynvim, inifile: setup.cfg, testpaths: test
collected 69 items / 1 deselected / 68 selected                                                                                                             

test/test_buffer.py::test_repr PASSED                                                                                                                 [  1%]
test/test_buffer.py::test_get_length PASSED                                                                                                           [  2%]
test/test_buffer.py::test_get_set_del_line PASSED                                                                                                     [  4%]
test/test_buffer.py::test_get_set_del_slice PASSED                                                                                                    [  5%]
test/test_buffer.py::test_vars PASSED                                                                                                                 [  7%]
test/test_buffer.py::test_api PASSED                                                                                                                  [  8%]
test/test_buffer.py::test_options PASSED                                                                                                              [ 10%]
test/test_buffer.py::test_number PASSED                                                                                                               [ 11%]
test/test_buffer.py::test_name PASSED                                                                                                                 [ 13%]
test/test_buffer.py::test_valid PASSED                                                                                                                [ 14%]
test/test_buffer.py::test_append PASSED                                                                                                               [ 16%]
test/test_buffer.py::test_mark PASSED                                                                                                                 [ 17%]
test/test_buffer.py::test_get_exceptions PASSED                                                                                                       [ 19%]
test/test_buffer.py::test_set_items_for_range PASSED                                                                                                  [ 20%]
test/test_buffer.py::test_update_highlights PASSED                                                                                                    [ 22%]
test/test_buffer.py::test_buffer_inequality PASSED                                                                                                    [ 23%]
test/test_client_rpc.py::test_call_and_reply PASSED                                                                                                   [ 25%]
test/test_client_rpc.py::test_call_api_before_reply PASSED                                                                                            [ 26%]
test/test_client_rpc.py::test_async_call PASSED                                                                                                       [ 27%]
test/test_client_rpc.py::test_recursion PASSED                                                                                                        [ 29%]
test/test_concurrency.py::test_interrupt_from_another_thread PASSED                                                                                   [ 30%]
test/test_concurrency.py::test_exception_in_threadsafe_call PASSED                                                                                    [ 32%]
test/test_decorators.py::test_command_count PASSED                                                                                                    [ 33%]
test/test_events.py::test_receiving_events PASSED                                                                                                     [ 35%]
test/test_events.py::test_sending_notify PASSED                                                                                                       [ 36%]
test/test_events.py::test_async_error PASSED                                                                                                          [ 38%]
test/test_events.py::test_broadcast PASSED                                                                                                            [ 39%]
test/test_host.py::test_host_imports PASSED                                                                                                           [ 41%]
test/test_host.py::test_host_clientinfo PASSED                                                                                                        [ 42%]
test/test_host.py::test_host_async_error PASSED                                                                                                       [ 44%]
test/test_logging.py::test_setup_logging PASSED                                                                                                       [ 45%]
test/test_tabpage.py::test_windows PASSED                                                                                                             [ 47%]
test/test_tabpage.py::test_vars PASSED                                                                                                                [ 48%]
test/test_tabpage.py::test_valid PASSED                                                                                                               [ 50%]
test/test_tabpage.py::test_number PASSED                                                                                                              [ 51%]
test/test_tabpage.py::test_repr PASSED                                                                                                                [ 52%]
test/test_vim.py::test_clientinfo PASSED                                                                                                              [ 54%]
test/test_vim.py::test_command PASSED                                                                                                                 [ 55%]
test/test_vim.py::test_command_output PASSED                                                                                                          [ 57%]
test/test_vim.py::test_command_error PASSED                                                                                                           [ 58%]
test/test_vim.py::test_eval PASSED                                                                                                                    [ 60%]
test/test_vim.py::test_call PASSED                                                                                                                    [ 61%]
test/test_vim.py::test_api PASSED                                                                                                                     [ 63%]
test/test_vim.py::test_strwidth PASSED                                                                                                                [ 64%]
test/test_vim.py::test_chdir PASSED                                                                                                                   [ 66%]
test/test_vim.py::test_current_line PASSED                                                                                                            [ 67%]
test/test_vim.py::test_current_line_delete PASSED                                                                                                     [ 69%]
test/test_vim.py::test_vars PASSED                                                                                                                    [ 70%]
test/test_vim.py::test_options PASSED                                                                                                                 [ 72%]
test/test_vim.py::test_local_options PASSED                                                                                                           [ 73%]
test/test_vim.py::test_buffers PASSED                                                                                                                 [ 75%]
test/test_vim.py::test_windows PASSED                                                                                                                 [ 76%]
test/test_vim.py::test_tabpages PASSED                                                                                                                [ 77%]
test/test_vim.py::test_hash PASSED                                                                                                                    [ 79%]
test/test_vim.py::test_cwd PASSED                                                                                                                     [ 80%]
test/test_vim.py::test_lua PASSED                                                                                                                     [ 82%]
test/test_window.py::test_buffer PASSED                                                                                                               [ 83%]
test/test_window.py::test_cursor PASSED                                                                                                               [ 85%]
test/test_window.py::test_height PASSED                                                                                                               [ 86%]
test/test_window.py::test_width PASSED                                                                                                                [ 88%]
test/test_window.py::test_vars PASSED                                                                                                                 [ 89%]
test/test_window.py::test_options PASSED                                                                                                              [ 91%]
test/test_window.py::test_position PASSED                                                                                                             [ 92%]
test/test_window.py::test_tabpage PASSED                                                                                                              [ 94%]
test/test_window.py::test_valid PASSED                                                                                                                [ 95%]
test/test_window.py::test_number PASSED                                                                                                               [ 97%]
test/test_window.py::test_handle PASSED                                                                                                               [ 98%]
test/test_window.py::test_repr PASSED                                                                                                                 [100%]

========================================================== 68 passed, 1 deselected in 3.00 seconds ==========================================================
maikwoehl updated this revision to Diff 31104.Jan 24 2022, 11:47 PM

Adding tests to check with new greenlet

Two tests are failing locally and in solbuild. I don't know why. :(

Use python-greenlet-devel in buildeps instead of python-greenlet. Be careful your release number jumped to "2", it should be "1".

Girtablulu requested changes to this revision.Jan 26 2022, 8:41 AM
This revision now requires changes to proceed.Jan 26 2022, 8:41 AM
maikwoehl updated this revision to Diff 31136.Jan 26 2022, 6:23 PM

Use python-greenlet-devel for building and reset release to 1

algent resigned from this revision.Jan 28 2022, 9:00 AM
algent removed a subscriber: algent.
Girtablulu accepted this revision.Feb 2 2022, 8:24 AM

LGTM, thx

This revision is now accepted and ready to land.Feb 2 2022, 8:24 AM
This revision was automatically updated to reflect the committed changes.