Page MenuHomeSolus

The inclusion of python-flask-socketio fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 9:49 PM.

Details

Summary

Used from onionshare-cli > flask-socketio

Depends on D12757

Test Plan

Use onionshare

Diff Detail

Repository
R5469 python-flask-socketio
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:49 PM
maikwoehl requested review of this revision.Jan 23 2022, 9:49 PM
maikwoehl retitled this revision from The inclusion of flask-socketio will fix T10009 to The inclusion of flask-socketio fixes T10009.Jan 23 2022, 10:22 PM
Girtablulu accepted this revision.Jan 24 2022, 10:27 AM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision is now accepted and ready to land.Jan 24 2022, 10:27 AM
algent added a subscriber: algent.Jan 25 2022, 11:18 AM

Can you rename this to python-flask-socketio? And you can remove the builddeps.

algent requested changes to this revision.Jan 26 2022, 12:29 PM
This revision now requires changes to proceed.Jan 26 2022, 12:29 PM
maikwoehl updated this revision to Diff 31132.Jan 26 2022, 6:02 PM

Renaming and updating deps

maikwoehl retitled this revision from The inclusion of flask-socketio fixes T10009 to The inclusion of python-flask-socketio fixes T10009.Jan 26 2022, 6:05 PM
algent resigned from this revision.Jan 28 2022, 8:59 AM
This revision is now accepted and ready to land.Jan 28 2022, 8:59 AM
algent removed a subscriber: algent.Jan 28 2022, 8:59 AM
This revision was automatically updated to reflect the committed changes.