Page MenuHomeSolus

The inclusion of python-socketio fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 9:46 PM.

Details

Summary

Used from onionshare-cli > flask-socketio > python-socketio

Depends on D12755
Depends on D12756

Test Plan

Use onionshare

Diff Detail

Repository
R5468 python-socketio
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:46 PM
maikwoehl requested review of this revision.Jan 23 2022, 9:46 PM
maikwoehl retitled this revision from The inclusion of python-socketio will fix T10009 to The inclusion of python-socketio fixes T10009.Jan 23 2022, 10:21 PM
Girtablulu accepted this revision.Jan 24 2022, 10:27 AM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision is now accepted and ready to land.Jan 24 2022, 10:27 AM
algent added a subscriber: algent.Jan 25 2022, 11:06 AM

Hey @maikwoehl let's do a few changes here.

  • remove builddeps because they are not needed, even if you add tests, there are no test in pypi tarball.
  • move python-requests and python-websocket-client as rundeps for python-engineio
algent requested changes to this revision.Jan 26 2022, 1:05 PM
This revision now requires changes to proceed.Jan 26 2022, 1:05 PM
maikwoehl updated this revision to Diff 31131.Jan 26 2022, 5:57 PM

Move python-requests and python-websocket-client to python-engineio

algent resigned from this revision.Jan 28 2022, 8:58 AM
This revision is now accepted and ready to land.Jan 28 2022, 8:58 AM
algent removed a subscriber: algent.Jan 28 2022, 8:58 AM
This revision was automatically updated to reflect the committed changes.