Page MenuHomeSolus

The inclusion of python-bidict fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 9:44 PM.

Details

Summary

Used from onionshare-cli > flask-socketio > python-socketio

Test Plan

Use onionshare and execute tests

Diff Detail

Repository
R5467 python-bidict
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:44 PM
maikwoehl requested review of this revision.Jan 23 2022, 9:44 PM
maikwoehl updated this revision to Diff 31073.Jan 23 2022, 9:47 PM
maikwoehl edited the summary of this revision. (Show Details)

Update diff description

maikwoehl edited the test plan for this revision. (Show Details)Jan 23 2022, 10:05 PM
maikwoehl retitled this revision from The inclusion of python-bidict will fix T10009 to The inclusion of python-bidict fixes T10009.Jan 23 2022, 10:21 PM
Girtablulu requested changes to this revision.Jan 24 2022, 10:26 AM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
11

Whiteline and can this a bit reduced?

28

as already asked, is it possible to not use tox?

This revision now requires changes to proceed.Jan 24 2022, 10:26 AM
algent added a subscriber: algent.Jan 24 2022, 7:48 PM

This package requires pytest==6.2.5
In my opinion remove networking : yes git python-tox and check.

maikwoehl updated this revision to Diff 31098.Jan 24 2022, 8:17 PM

Remove check because pytest 6.2.5 is not supported by repo

maikwoehl marked 2 inline comments as done.Jan 24 2022, 8:17 PM

i'll take a look at packaging python2-pytest in a separate package to unblock it's update. Our pytest _super_ old now.

Girtablulu accepted this revision.Jan 24 2022, 9:17 PM

LGTm, thx

This revision is now accepted and ready to land.Jan 24 2022, 9:17 PM
algent removed a subscriber: algent.Jan 28 2022, 9:02 AM
This revision was automatically updated to reflect the committed changes.