The inclusion of python-engineio fixes T10009
ClosedPublic
Actions

Authored by maikwoehl on Jan 23 2022, 9:42 PM.

Details

Reviewers

Girtablulu
algent

Group Reviewers

Triage Team

Commits

R5466:d2c8d0b89413: The inclusion of python-engineio fixes T10009

Summary

Used from onionshare-cli > flask-socketio > python-socketio

Test Plan

Use onionshare and execute tests

Diff Detail

Repository

R5466 python-engineio

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:42 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 23 2022, 9:42 PM

maikwoehl requested review of this revision.Jan 23 2022, 9:42 PM

Harbormaster completed remote builds in B3124: Diff 31069.Jan 23 2022, 9:43 PM

maikwoehl added a child revision: D12757: The inclusion of python-socketio fixes T10009.Jan 23 2022, 9:46 PM

kyrios123 retitled this revision from The inclusion of python-engineio will fix T10009 to The inclusion of python-engineio fixes T10009.Jan 23 2022, 9:47 PM

maikwoehl edited the test plan for this revision. (Show Details)Jan 23 2022, 10:04 PM

LGTM, thx

This revision is now accepted and ready to land.Jan 24 2022, 10:25 AM

Test are not included in pypi tarball. You can remove them.

algent requested changes to this revision.Jan 26 2022, 1:04 PM

This revision now requires changes to proceed.Jan 26 2022, 1:04 PM

Removing tests

Harbormaster completed remote builds in B3165: Diff 31129.Jan 26 2022, 5:51 PM

Add python-requests and python-websocket-client as rundeps

Harbormaster completed remote builds in B3166: Diff 31130.Jan 26 2022, 5:55 PM

algent removed a subscriber: algent.Jan 28 2022, 8:54 AM

algent resigned from this revision.Jan 28 2022, 8:58 AM

This revision is now accepted and ready to land.Jan 28 2022, 8:58 AM

Closed by commit R5466:d2c8d0b89413: The inclusion of python-engineio fixes T10009 (authored by maikwoehl, committed by Girtablulu). · Explain WhyFeb 20 2022, 10:43 AM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5466:d2c8d0b89413: The inclusion of python-engineio fixes T10009.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

17 lines

83 lines

Diff 31503

View Options

MAINTAINERS.md

View Options

Makefile

View Options

package.yml

View Options

The inclusion of python-engineio fixes T10009ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31503

MAINTAINERS.md

Makefile

package.yml

pspec_x86_64.xml

The inclusion of python-engineio fixes T10009
ClosedPublic
Actions

Revision Contents
Changeset List