The inclusion of python-engineio fixes T10009
ClosedPublic
Actions

Authored by maikwoehl on Jan 23 2022, 9:42 PM.

Details

Reviewers

Girtablulu
algent

Group Reviewers

Triage Team

Commits

R5466:d2c8d0b89413: The inclusion of python-engineio fixes T10009

Summary

Used from onionshare-cli > flask-socketio > python-socketio

Test Plan

Use onionshare and execute tests

Diff Detail

Repository

R5466 python-engineio

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:42 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 23 2022, 9:42 PM

maikwoehl requested review of this revision.Jan 23 2022, 9:42 PM

Harbormaster completed remote builds in B3124: Diff 31069.Jan 23 2022, 9:43 PM

maikwoehl added a child revision: D12757: The inclusion of python-socketio fixes T10009.Jan 23 2022, 9:46 PM

kyrios123 retitled this revision from The inclusion of python-engineio will fix T10009 to The inclusion of python-engineio fixes T10009.Jan 23 2022, 9:47 PM

maikwoehl edited the test plan for this revision. (Show Details)Jan 23 2022, 10:04 PM

LGTM, thx

This revision is now accepted and ready to land.Jan 24 2022, 10:25 AM

Test are not included in pypi tarball. You can remove them.

algent requested changes to this revision.Jan 26 2022, 1:04 PM

This revision now requires changes to proceed.Jan 26 2022, 1:04 PM

Removing tests

Harbormaster completed remote builds in B3165: Diff 31129.Jan 26 2022, 5:51 PM

Add python-requests and python-websocket-client as rundeps

Harbormaster completed remote builds in B3166: Diff 31130.Jan 26 2022, 5:55 PM

algent removed a subscriber: algent.Jan 28 2022, 8:54 AM

algent resigned from this revision.Jan 28 2022, 8:58 AM

This revision is now accepted and ready to land.Jan 28 2022, 8:58 AM

Closed by commit R5466:d2c8d0b89413: The inclusion of python-engineio fixes T10009 (authored by maikwoehl, committed by Girtablulu). · Explain WhyFeb 20 2022, 10:43 AM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5466:d2c8d0b89413: The inclusion of python-engineio fixes T10009.

Revision Contents
Changeset List

		Path
A	M	MAINTAINERS.md (5 lines)
A	M	Makefile (1 line)
A	M	package.yml (17 lines)
A	M	pspec_x86_64.xml (83 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31069	4b825dc		Jan 23 2022, 9:42 PM	★	★
Diff 2	31129	4b825dc	Removing tests	Jan 26 2022, 5:51 PM	★	★
Diff 3	31130	4b825dc	Add python-requests and python-websocket-client as rundeps	Jan 26 2022, 5:55 PM	★	★
Diff 4	31503	a24e677	R5466:d2c8d0b8941370687209484f470f7807265c9379	Feb 20 2022, 10:43 AM	★	★

Status	Author	Revision
Closed	maikwoehl	D12766 Update of onionshare to version 2.5 fixes T10009
Closed	maikwoehl	D12765 The inclusion of onionshare-cli fixes T10009
Closed	maikwoehl	D12763 The inclusion of python-gevent-websocket fixes T10009
Closed	maikwoehl	D12762 The inclusion of python-gevent fixes T10009
Closed	maikwoehl	D12761 The inclusion of python-eventlet fixes T10009
Closed	maikwoehl	D12760 The update of python-greenlet fixes T10009
Closed	maikwoehl	D12759 The inclusion of python-cepa fixes T10009
Closed	maikwoehl	D12758 The inclusion of python-flask-socketio fixes T10009
Closed	maikwoehl	D12757 The inclusion of python-socketio fixes T10009
Closed	maikwoehl	D12756 The inclusion of python-bidict fixes T10009
Closed	maikwoehl	D12755 The inclusion of python-engineio fixes T10009
Closed	maikwoehl	D12764 The inclusion of python-qrcode fixes T10009