Page MenuHomeSolus

The inclusion of python-engineio fixes T10009
ClosedPublic

Authored by maikwoehl on Jan 23 2022, 9:42 PM.

Details

Summary

Used from onionshare-cli > flask-socketio > python-socketio

Test Plan

Use onionshare and execute tests

Diff Detail

Repository
R5466 python-engineio
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Jan 23 2022, 9:42 PM
maikwoehl requested review of this revision.Jan 23 2022, 9:42 PM
kyrios123 retitled this revision from The inclusion of python-engineio will fix T10009 to The inclusion of python-engineio fixes T10009.Jan 23 2022, 9:47 PM
maikwoehl edited the test plan for this revision. (Show Details)Jan 23 2022, 10:04 PM
Girtablulu accepted this revision.Jan 24 2022, 10:25 AM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision is now accepted and ready to land.Jan 24 2022, 10:25 AM
algent added a subscriber: algent.Jan 25 2022, 11:08 AM

Test are not included in pypi tarball. You can remove them.

algent requested changes to this revision.Jan 26 2022, 1:04 PM
This revision now requires changes to proceed.Jan 26 2022, 1:04 PM
maikwoehl updated this revision to Diff 31129.Jan 26 2022, 5:51 PM

Removing tests

maikwoehl updated this revision to Diff 31130.Jan 26 2022, 5:55 PM

Add python-requests and python-websocket-client as rundeps

algent removed a subscriber: algent.Jan 28 2022, 8:54 AM
algent resigned from this revision.Jan 28 2022, 8:58 AM
This revision is now accepted and ready to land.Jan 28 2022, 8:58 AM
This revision was automatically updated to reflect the committed changes.