Paths

Table of Contentst

Differential D12744

initial inclusion of ziglang
ClosedPublic
Actions

Authored by nazar on Jan 22 2022, 11:22 PM.

Tags

None

Referenced Files

	F11034189: D12744.id31043.diff
	Wed, Aug 9, 4:31 PM

	F11034188: D12744.id31216.diff
	Wed, Aug 9, 4:30 PM

	F11034187: D12744.id31128.diff
	Wed, Aug 9, 4:30 PM

	F11034186: D12744.id31049.diff
	Wed, Aug 9, 4:30 PM

	F11034185: D12744.id31139.diff
	Wed, Aug 9, 4:30 PM

	F11034184: D12744.id.diff
	Wed, Aug 9, 4:30 PM

	F11034183: D12744.id31044.diff
	Wed, Aug 9, 4:30 PM

	F11026372: D12744.diff
	Wed, Aug 9, 2:14 AM

View All 18 Files

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T9346: zig/ziglang

Commits

R5456:be0ca8b86cad: initial inclusion of ziglang

Summary

General-purpose programming language and toolchain for maintaining robust, optimal, and reusable software. Resolves T9346

Test Plan

$workdir/zig init-exe
$workdir/zig build run
$workdir/zig build test

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 3112
Build 3112: arc lint + arc unit

Event Timeline

nazar created this revision.Jan 22 2022, 11:22 PM

Harbormaster completed remote builds in B3106: Diff 31043.Jan 22 2022, 11:22 PM

nazar requested review of this revision.Jan 22 2022, 11:22 PM

Few small changes needed

package.yml
14	cmake is in system.devel component. Anything in system.base or system.devel doesn't need to be added to builddeps.
16	llvm-clang-devel will bring this in already
17	Won't need the explicit llvm rundep here as libLLVM-13.so is listed in abi_used_libs
20	Could we also pass `-DZIG_PREFER_CLANG_CPP_DYLIB=ON` to link against `libclang-cpp.so` as well

This revision now requires changes to proceed.Jan 22 2022, 11:42 PM

nazar edited the test plan for this revision. (Show Details)Jan 22 2022, 11:49 PM

applying requested changes

Harbormaster completed remote builds in B3107: Diff 31044.Jan 23 2022, 12:25 AM

nazar edited the test plan for this revision. (Show Details)Jan 23 2022, 1:31 AM

add checks

Harbormaster completed remote builds in B3112: Diff 31049.Jan 23 2022, 1:48 AM

Just two nits. Otherwise looks good to me, can land post sync.

package.yml
11	nit : correct number of spaces
15	nit: our cmake macro sets RelWithDebug, use `optimize : speed` if you want to build with `-O3`.

This revision now requires changes to proceed.Jan 26 2022, 4:36 PM

set build_type to RelWithDebug

Harbormaster completed remote builds in B3164: Diff 31128.Jan 26 2022, 4:41 PM

Sorry I mean just remove CMAKE_BUILD_TYPE, it gets set in the macro : see https://github.com/getsolus/ypkg/blob/master/ypkg2/rc.yml#L14

CMAKE_BUILD_TYPE is not necessary

Harbormaster completed remote builds in B3175: Diff 31139.Jan 26 2022, 6:31 PM

nazar edited reviewers, added: Triage Team; removed: joebonrichie.Jan 28 2022, 2:31 PM

joebonrichie accepted this revision.Feb 1 2022, 9:42 PM

This revision is now accepted and ready to land.Feb 1 2022, 9:42 PM

Closed by commit R5456:be0ca8b86cad: initial inclusion of ziglang (authored by nazar, committed by joebonrichie). · Explain WhyFeb 1 2022, 9:43 PM

This revision was automatically updated to reflect the committed changes.

joebonrichie added a commit: R5456:be0ca8b86cad: initial inclusion of ziglang.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

7 lines

abi_used_symbols

1475 lines

26 lines

pspec_x86_64.xml

13248 lines

Diff 31049

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...