Page MenuHomeSolus

Update qspeakers to 1.6.2
ClosedPublic

Authored by be1 on Jan 17 2022, 7:10 PM.
Tags
None
Referenced Files
F10878183: D12673.id30879.diff
Jun 21 2023, 4:58 AM
F10876719: D12673.id31812.diff
Jun 20 2023, 12:40 PM
F10875648: D12673.id30934.diff
Jun 20 2023, 6:47 AM
F10875509: D12673.id30925.diff
Jun 20 2023, 6:04 AM
F10870749: D12673.diff
Jun 18 2023, 10:48 AM
F10794869: D12673.diff
May 27 2023, 5:57 PM
F10753025: D12673.id.diff
May 16 2023, 4:52 PM
F10724629: D12673.id.diff
May 7 2023, 5:44 PM
Tokens
"Mountain of Wealth" token, awarded by davidjharder.

Details

Summary

This version now adds a value picker on left-click to the curve area.

Test Plan

start program, select a loudspeaker in the database, click on 'optimize' button, click on the curve area and observe tooltip displaying detailed values.

Diff Detail

Repository
R5238 qspeakers
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

be1 requested review of this revision.Jan 17 2022, 7:10 PM
be1 retitled this revision from New uptream release. to QSpeakers: New uptream release..Jan 17 2022, 7:12 PM
be1 set the repository for this revision to R5238 qspeakers.
Girtablulu added a subscriber: Girtablulu.

you need to build this against master, you updated against your old arc patch

This revision now requires changes to proceed.Jan 18 2022, 10:17 PM

New QSpeakers release: Improves curve reading by adding values picker on left-click.

made:

$ git clone http://dev.getsol.us/source/qspeakers.git
modified and added files
$ git commit -a -m "QSpekaers: New uptream release 1.6.2."
$ arc diff

but it doesn't seem to be the right way... need help please.

Clone a fresh copy:
  git clone http://dev.getsol.us/source/qspeakers.git
make your changes,
make a commit with the changes:
  make clean
  git add .
  git commit -m "Update qspeakers to 1.6.2"
Force arcanist to update this diff:
  arc diff --update D12673
Don't worry about filling out "Summary" and Test Plan" in the terminal if you don't want to, easy enough to do it on the website

Hop on IRC to get more help, we're friendly!

ref: https://secure.phabricator.com/book/phabricator/article/arcanist_diff/

Update qspeakers to 1.6.2

kyrios123 added a subscriber: kyrios123.

Please rename your revision into

  • Update qspeakers to 1.6.2

or eventually to

  • Update to 1.6.2

Summary should contain a summarized changelog or eventually a link to the upstream changelog for the given release if it is very long.

This revision now requires changes to proceed.Jan 19 2022, 4:39 PM
be1 retitled this revision from QSpeakers: New uptream release. to Update qspeakers to 1.6.2.Jan 19 2022, 5:13 PM
be1 edited the summary of this revision. (Show Details)
be1 edited the test plan for this revision. (Show Details)

please remember for the next time, if we request changes you need to change the status as well when you doing anything manually or we will miss it :)

LGTM, thx

This revision is now accepted and ready to land.Mar 12 2022, 11:07 PM
This revision was automatically updated to reflect the committed changes.