Page MenuHomeSolus

updates sdcv to 0.5.3
ClosedPublic

Authored by nazar on Jan 17 2022, 6:50 PM.
Tags
None
Referenced Files
F11065414: D12672.id30878.diff
Fri, Aug 11, 4:36 PM
F11065413: D12672.id.diff
Fri, Aug 11, 4:36 PM
F11065412: D12672.id31053.diff
Fri, Aug 11, 4:36 PM
F11065411: D12672.id30883.diff
Fri, Aug 11, 4:36 PM
F11065410: D12672.id30888.diff
Fri, Aug 11, 4:36 PM
F11046658: D12672.diff
Thu, Aug 10, 1:56 PM
F10998907: D12672.id30888.diff
Fri, Jul 28, 6:06 AM
F10952684: D12672.diff
Sun, Jul 16, 5:39 PM
Subscribers

Details

Summary

Changelog

  • Use single quotes around JSON data to reduce need for escaping
  • Store integer magic in cache file
  • Added $SDCV_HISTFILE to set history file
  • return exit code 2 if search term not found
  • Comply with the XDG Base Directory Specification
Test Plan

build, install and look up new word

Diff Detail

Repository
R3721 sdcv
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2998
Build 2998: arc lint + arc unit

Event Timeline

nazar requested review of this revision.Jan 17 2022, 6:50 PM
nazar created this revision.
nazar edited the test plan for this revision. (Show Details)

Hi @nazar. Changes in abi_* files are veryt important, you have to submit them too in this diff. So, everything that is in build folder except .eopkg file should be submited in the diff.

hi @algent, sdcv already exists in repo, this is just an update 0.5.2->0.5.3. Also git diff is clean, means no changes were made to abi* files, am I doing it right?

I did same thing as you and I had changes:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   abi_used_symbols
	modified:   package.yml
	modified:   pspec_x86_64.xml

no changes added to commit (use "git add" and/or "git commit -a")

@algent, I double checked: my git status is what I submitted with patch, could it be white-space changes to abi_used_symbols in your case?

On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   package.yml
	modified:   pspec_x86_64.xml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	sdcv-0.5.3-4-1-x86_64.eopkg

no changes added to commit (use "git add" and/or "git commit -a")

Maybe my PC acts differently:
https://www.toptal.com/developers/hastebin/nubuqasubo.diff

In your case you have only package.yml and pspec_x86_64.xml are modified, so it is fine I think.

About pspec_x86_64.xml you have to use your real name not your nick as it is here <Name>nazar</Name>

@nazar what repo are you using, stable shannon or unstable repo? Check it with eopkg lr.

Solus [active]

https://mirrors.rit.edu/solus/packages/shannon/eopkg-index.xml.xz
nazar edited the summary of this revision. (Show Details)

missed file

  • fixed name in packagers file
kyrios123 retitled this revision from updates sdcv to latest release: 0.5.3 to updates sdcv to 0.5.3.Jan 17 2022, 10:04 PM

@nazar have you build this now against unstable?

This revision is now accepted and ready to land.Jan 23 2022, 12:26 PM
This revision was automatically updated to reflect the committed changes.