Page MenuHomeSolus

Bump the version to 1.10.3.1058
ClosedPublic

Authored by oly on Jan 12 2022, 7:52 PM.
Tags
None
Referenced Files
F11013634: D12640.id30783.diff
Fri, Aug 4, 4:18 PM
F10984972: D12640.id30782.diff
Sun, Jul 23, 7:48 PM
F10965511: D12640.id30792.diff
Wed, Jul 19, 9:58 PM
F10964754: D12640.id30910.diff
Wed, Jul 19, 2:05 PM
F10945053: D12640.id30783.diff
Sat, Jul 15, 2:34 AM
F10866788: D12640.diff
Jun 17 2023, 5:17 PM
F10800555: D12640.id30755.diff
May 28 2023, 8:50 PM
F10800254: D12640.id30782.diff
May 28 2023, 6:51 PM

Details

Summary

Release notes available here

Test Plan
  • Built and installed locally

Diff Detail

Repository
R5349 clojure-tools
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

oly requested review of this revision.Jan 12 2022, 7:52 PM
joebonrichie added a subscriber: joebonrichie.

Need to say how you tested it rather than just installed - just testing basic functionality is enough. A couple of nit's in the package.yml as well.

package.yml
2

Double bumped the release

14

random 4 needs deleting.

This revision now requires changes to proceed.Jan 13 2022, 6:03 PM

Removed stray char and reduce version bump to 2 updated commit comments.

Forgot to rerun the build for the new spec yaml file

Since I know you use clojure extensively i'll let this in without a proper test plan. In a the future a basic test plan such as "compiled hello-world example" is enough.

This revision is now accepted and ready to land.Jan 13 2022, 9:16 PM

Right, this diff is not applied on the lastest git head which is version 1.10.3.1040 this patch is applying on top of 1.10.3.1020. Need to rework the patch to on top of the latest git head.

This revision now requires changes to proceed.Jan 13 2022, 9:18 PM
oly marked 2 inline comments as done.

Updatng clojure to the latest version, reset local to origin/master

reapplied the package.yml and pspec files on top of origin/master

Right, this diff is not applied on the lastest git head which is version 1.10.3.1040 this patch is applying on top of 1.10.3.1020. Need to rework the patch to on top of the latest git head.

Not sure how i managed that, I have reset my local to origin/master and applied tehe changes on top again hopefully that solves it.

I am curious can i include unrelated files in the repo like a file on the update steps and how to test to remind me next time around, if so I may do this on the next update ?

I also tested with clj -e '(prn "hi")' to make sure the code evaluated.

package.yml
2

This was done by the package updater script for some reason, I guess technically it is 3 as the this is the 3rd revision so perhaps the last version was not bumped when it should have been ?

Girtablulu removed a reviewer: joebonrichie.
Girtablulu added a subscriber: Girtablulu.

LGTm, thx

This revision is now accepted and ready to land.Jan 18 2022, 9:59 PM
This revision was automatically updated to reflect the committed changes.