Page MenuHomeSolus

Make it actually work.
AbandonedPublic

Authored by As4fN1v on Oct 28 2017, 6:42 AM.

Details

Reviewers
None
Group Reviewers
Triage Team

Diff Detail

Repository
R1957 lightdm-gtk-greeter-settings
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

As4fN1v created this revision.Oct 28 2017, 6:42 AM
DataDrake abandoned this revision.Oct 28 2017, 10:56 AM
DataDrake added a subscriber: DataDrake.
  1. That statelessness patch is not hurting anything and is part of our goal to make all of Solus follow the principle of stateless design.
  1. From your diff, it looks like we might need a rebuild of the package, but you didn't even bump the release number.

If you are having an issue with lightdm then you really should be submitting a bug report so that it will both be fixed now and recorded so that it doesn't get broken again in the future. Without knowing what went wrong in the first place, there's no way for us to do that.

  1. That statelessness patch is not hurting anything and is part of our goal to make all of Solus follow the principle of stateless design.
  2. From your diff, it looks like we might need a rebuild of the package, but you didn't even bump the release number.

If you are having an issue with lightdm then you really should be submitting a bug report so that it will both be fixed now and recorded so that it doesn't get broken again in the future. Without knowing what went wrong in the first place, there's no way for us to do that.

That patch made it NOT save settings.

Then the patch needs to be fixed, not removed. And I need a bug report that actually says what broke and why it broke because no one has reported it. All you did was submit a patch with no description of what it does or what you were trying to do.