Page MenuHomeSolus

Update firefox to 56.0.2
ClosedPublic

Authored by kyrios123 on Oct 25 2017, 7:17 PM.
Tags
None
Referenced Files
F11067656: D1253.diff
Fri, Aug 11, 8:58 PM
F11018610: D1253.diff
Sun, Aug 6, 1:29 PM
F11011021: D1253.diff
Thu, Aug 3, 11:58 AM
F10995639: D1253.id3054.diff
Wed, Jul 26, 6:00 AM
F10982413: D1253.id3055.diff
Sun, Jul 23, 10:23 AM
F10980085: D1253.id3056.diff
Sun, Jul 23, 2:16 AM
F10971640: D1253.diff
Fri, Jul 21, 8:01 AM
F10971116: D1253.id3116.diff
Fri, Jul 21, 5:52 AM
Subscribers

Details

Summary

Release notes available here

  • Enable stylo
  • Backport patches to repair broken flash player

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Browse a few sites and play a video on YT.
  • Test pages containing flash stuffs.

Diff Detail

Repository
R755 firefox
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

If we build with --enable-stylo does that enable stylo by default or does it hide behind layout.css.servo.enabled?

Also does --enable-system-hunspell work again?

@joebonrichie I haven't tried stylo so far. I think it was introduced with FF 56.0 and Ikey disabled it because the upgrade was PITA and he didn't want to wait any longer for pushing the update. I might eventually have a look at it tomorrow.

Hunspell can be enabled back with D943 but not with the version that is currently in the repository.

The CFLAGS and the CXXFLAGS are probably something that should be looked at. A few releases back, I made a build without them and Firefox was working fine on my VM. But I am still a newbie and this is Greek to me.

# GCC6 produces completely broken Firefox
export CFLAGS="$CFLAGS -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2"
export CXXFLAGS="$CXXFLAGS -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2"

While doing a "to-do list" for Firefox, I also wonder:
Why do we --disable-optimize ? Does it conflict with Solus own optimizations ?
If it doesn't have a significant impact on the performances, wouldn't it be a good idea to --enable-pie to improve the security ?

Ping: @ikey

Enable stylo + attempt to fix broken plugins like flash

Fully fix broken flash player in Firefox

kyrios123 edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Oct 30 2017, 3:37 PM
This revision was automatically updated to reflect the committed changes.