Details
- Reviewers
ikey - Group Reviewers
Triage Team - Commits
- R755:c8254085d3cb: Update firefox to 56.0.2
- Browse a few sites and play a video on YT.
- Test pages containing flash stuffs.
Diff Detail
- Repository
- R755 firefox
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
If we build with --enable-stylo does that enable stylo by default or does it hide behind layout.css.servo.enabled?
@joebonrichie I haven't tried stylo so far. I think it was introduced with FF 56.0 and Ikey disabled it because the upgrade was PITA and he didn't want to wait any longer for pushing the update. I might eventually have a look at it tomorrow.
Hunspell can be enabled back with D943 but not with the version that is currently in the repository.
The CFLAGS and the CXXFLAGS are probably something that should be looked at. A few releases back, I made a build without them and Firefox was working fine on my VM. But I am still a newbie and this is Greek to me.
# GCC6 produces completely broken Firefox export CFLAGS="$CFLAGS -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2" export CXXFLAGS="$CXXFLAGS -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2"
While doing a "to-do list" for Firefox, I also wonder:
Why do we --disable-optimize ? Does it conflict with Solus own optimizations ?
If it doesn't have a significant impact on the performances, wouldn't it be a good idea to --enable-pie to improve the security ?
Ping: @ikey