Page MenuHomeSolus

Initial commit for librime, version 1.7.2
ClosedPublic

Authored by GZGavinZhao on Dec 25 2021, 10:05 PM.

Details

Summary

Depends on D12532.

Initial commit for Rime Input Method Engine, the core library.

A few notes:

  • 1.7.3 was tagged but not released, hence just for safety 1.7.2 is used.
  • This package also includes plum, the Rime configuration manager and input schema repository. Usually this is packaged to a standlone package called rime-plum or rime-data, as seen for Arch and Debian. However, since it is not tagged and has no versioning, it is included in librime and the version will be determined by the submodule version in ibus-rime.
    • It's not included in ibus-rime because ibus-rime's build process require its cmake config file, which cannot be installed and detected by cmake if they're in the same package and being built together.
    • For reference, here's the official guidance for downstream package managers on plum: https://github.com/rime/plum#install-as-shared-data
Test Plan

Successfully built and ran ibus-rime.

Signed-off-by: Gavin Zhao <gavinzhaojw@protonmail.com>

Diff Detail

Repository
R5405 librime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

GZGavinZhao created this revision.Dec 25 2021, 10:05 PM
GZGavinZhao requested review of this revision.Dec 25 2021, 10:05 PM
JoshStrobl requested changes to this revision.Dec 27 2021, 7:20 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
26

No. Only what is necessary to be listed should be listed.

This revision now requires changes to proceed.Dec 27 2021, 7:20 PM
GZGavinZhao marked an inline comment as done.

Fix requested changes.

libboost actually can use CXX11. I turned it off because I thought it was the problem of a local build failure, but after fixing it I forgot to turn it back on.

Girtablulu accepted this revision.Jan 9 2022, 7:54 PM
Girtablulu added a subscriber: Girtablulu.

LGTM,thx

This revision is now accepted and ready to land.Jan 9 2022, 7:57 PM
This revision was automatically updated to reflect the committed changes.