Page MenuHomeSolus

Initial commit for marisa, version 0.2.6
ClosedPublic

Authored by GZGavinZhao on Dec 25 2021, 9:51 PM.

Details

Summary

Initial commit for marisa, Matching Algorithm with Recursively Implemented StorAge.

Dependency for librime.

Test Plan

Successfully built and ran librime.

Signed-off-by: Gavin Zhao <gavinzhaojw@protonmail.com>

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2847
Build 2847: arc lint + arc unit

Event Timeline

GZGavinZhao created this revision.Dec 25 2021, 9:51 PM
GZGavinZhao requested review of this revision.Dec 25 2021, 9:51 PM
GZGavinZhao edited the summary of this revision. (Show Details)Dec 25 2021, 9:52 PM
JoshStrobl requested changes to this revision.Dec 27 2021, 7:18 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
2

name should be marisa-trie

8

programming.library

14

This is done by our reconfigure macro and thus is redundant.

18

This should be done during check stage, not during install, using %make check

pspec_x86_64.xml
56

Static libs need to be disabled

This revision now requires changes to proceed.Dec 27 2021, 7:18 PM
GZGavinZhao marked 4 inline comments as done.

Fix requested changes.

Girtablulu accepted this revision.Jan 9 2022, 7:53 PM
Girtablulu added a subscriber: Girtablulu.

LGTM, thx

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2022, 7:57 PM
This revision was automatically updated to reflect the committed changes.