Differential D12532

Initial commit for marisa, version 0.2.6
ClosedPublic
Actions

Authored by GZGavinZhao on Dec 25 2021, 9:51 PM.

Tags

None

Subscribers

Girtablulu, JoshStrobl

Details

Reviewers

Group Reviewers

Commits

R5404:c0942dadde65: Initial commit for marisa, version 0.2.6

Summary

Initial commit for marisa, Matching Algorithm with Recursively Implemented StorAge.

Dependency for librime.

Test Plan

Successfully built and ran librime.

Signed-off-by: Gavin Zhao <gavinzhaojw@protonmail.com>

Diff Detail

Repository

R5404 marisa-trite

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

GZGavinZhao created this revision.Dec 25 2021, 9:51 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 25 2021, 9:51 PM

Harbormaster completed remote builds in B2822: Diff 30528.Dec 25 2021, 9:51 PM

GZGavinZhao requested review of this revision.Dec 25 2021, 9:51 PM

GZGavinZhao edited the summary of this revision. (Show Details)Dec 25 2021, 9:52 PM

GZGavinZhao added a child revision: D12533: Initial commit for librime, version 1.7.2.Dec 25 2021, 10:05 PM

JoshStrobl requested changes to this revision.Dec 27 2021, 7:18 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
2	name should be marisa-trie
8	programming.library
14	This is done by our reconfigure macro and thus is redundant.
18	This should be done during check stage, not during install, using `%make check`
pspec_x86_64.xml
56	Static libs need to be disabled

This revision now requires changes to proceed.Dec 27 2021, 7:18 PM

Fix requested changes.

Harbormaster completed remote builds in B2847: Diff 30565.Dec 27 2021, 8:54 PM

LGTM, thx

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2022, 7:57 PM

Closed by commit R5404:c0942dadde65: Initial commit for marisa, version 0.2.6 (authored by GZGavinZhao, committed by Girtablulu). · Explain Why

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5404:c0942dadde65: Initial commit for marisa, version 0.2.6.

Girtablulu removed a reviewer: JoshStrobl.Jan 9 2022, 7:59 PM

Revision Contents
Changeset List

			Path	Packages
A	M		MAINTAINERS.md (5 lines)
A	M		Makefile (1 line)
A	M		abi_libs (1 line)
A	M		abi_symbols (150 lines)
A	M		abi_used_libs (3 lines)
A	M		abi_used_symbols (88 lines)
A	M		package.yml (18 lines)
A	M		pspec_x86_64.xml (68 lines)

Diff 30731

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...