Page MenuHomeSolus

Initial commit of intel-media-driver
ClosedPublic

Authored by serebit on Dec 25 2021, 8:50 PM.

Details

Summary

Starting with the latest quarterly release, v21.3.5. Initial package.yml written by @ReillyBrogan. Resolves T9590.

Test Plan
  • Run vainfo
  • Decode an H.264 video using ffmpeg with an Intel i5-7200U, verify the difference in speed and CPU usage between hardware decoding and software decoding, check intel-gpu-top to verify that the video encoder is working
  • Use VLC with VA-API decoding to watch a good scene in a legally procured digital copy of The Mask

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2835
Build 2835: arc lint + arc unit

Event Timeline

serebit created this revision.Dec 25 2021, 8:50 PM
serebit requested review of this revision.Dec 25 2021, 8:50 PM
serebit edited the summary of this revision. (Show Details)Dec 25 2021, 8:51 PM
serebit added a subscriber: ReillyBrogan.
JoshStrobl requested changes to this revision.Dec 25 2021, 8:56 PM
JoshStrobl added a reviewer: joebonrichie.
JoshStrobl added subscribers: joebonrichie, JoshStrobl.

LGTM otherwise. Nice work by yourself and @ReillyBrogan.

Is this something you and @ReillyBrogan are willing to maintain? I don't have any Intel hardware at this time to validate the package, otherwise I'd probably assign myself.

Prodding @joebonrichie also per IRC convo re. "taking priority if libva-intel-driver is installed as well, otherwise needs a conflicts or hack in libva".

package.yml
9

B comes before M

This revision now requires changes to proceed.Dec 25 2021, 8:56 PM
serebit added inline comments.Dec 25 2021, 9:03 PM
package.yml
9

letters are hard

serebit edited the test plan for this revision. (Show Details)Dec 25 2021, 9:11 PM
serebit edited the test plan for this revision. (Show Details)Dec 25 2021, 9:26 PM

With both installed, all software I've tested has been using intel-media-driver rather than libva-intel-driver.

Reilly doesn't have hardware to test this, so I'm fine with maintaining it. I'm already maintaining the rest of the stack anyway.

serebit marked an inline comment as done.Dec 26 2021, 6:48 PM
JoshStrobl requested changes to this revision.Dec 27 2021, 2:55 PM
JoshStrobl added inline comments.
package.yml
9

plz fiz

This revision now requires changes to proceed.Dec 27 2021, 2:55 PM
JoshStrobl added inline comments.Dec 27 2021, 2:56 PM
package.yml
9

also fix my fiz, whatever that is

JoshStrobl accepted this revision.Dec 27 2021, 7:06 PM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 27 2021, 7:06 PM
This revision was automatically updated to reflect the committed changes.