Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Also missing a summary and test plan for the patch and in the future, don't submit patches for things not yet accepted for inclusion.
| package.yml | ||
|---|---|---|
| 5 | Need to use a sourceforge mirror URL. | |
| 9 | Not sure why this was changed from the correct and default : | block. You did actually generate the package.yml via this, right? | |
| 11 | Should be using pkgconfig(libnih) if it's needed as a builddep and make sure to add libnih as a rundep if it doesn't show up in the abi_used_libs. | |
| 12 | Part of system.base, not needed. | |
| 13 | Part of system.base, not needed. | |