Page MenuHomeSolus

Initial commit of adios2
ClosedPublic

Authored by YakoYakoYokuYoku on Nov 16 2021, 8:56 PM.

Details

Summary

Dependency of VTK.

Depends on D12322, D12323, D12324 and D12325.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Built VTK against it.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2489
Build 2489: arc lint + arc unit

Event Timeline

YakoYakoYokuYoku requested review of this revision.Nov 16 2021, 8:56 PM

Relocate missing symbols.

joebonrichie requested changes to this revision.Nov 18 2021, 3:32 PM
joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
pspec_x86_64.xml
140

A lot of these cmake files look a bit suspect. Surely we would just need the /usr/lib64/cmake/adios2/adios2*.cmake files?

This revision now requires changes to proceed.Nov 18 2021, 3:32 PM
YakoYakoYokuYoku marked an inline comment as done.Nov 18 2021, 6:41 PM
YakoYakoYokuYoku added inline comments.
pspec_x86_64.xml
140

It pushes and pops the CMAKE_MODULE_PATH variable, so it won't hurt either.

YakoYakoYokuYoku requested review of this revision.Nov 18 2021, 6:41 PM
YakoYakoYokuYoku marked an inline comment as done.
DataDrake accepted this revision.Jan 14 2022, 7:15 PM
DataDrake removed a reviewer: joebonrichie.
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2022, 7:15 PM
This revision was automatically updated to reflect the committed changes.