Page MenuHomeSolus

Initial commit of pcl
ClosedPublic

Authored by algent on Nov 16 2021, 8:46 PM.

Details

Summary

Dependency of pdal.

Depends on D12319.

Test Plan

Built pdal against it.

Diff Detail

Repository
R5409 pcl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Nov 16 2021, 8:46 PM

Place CMake configs correctly.

Rebuild against libboost update.

JoshStrobl added inline comments.
package.yml
31

This is being added to the main package. Is this intentional?

YakoYakoYokuYoku marked an inline comment as done.

Apply suggested changes.

joebonrichie added a subscriber: joebonrichie.

Rebuild against libboost 1.78.0

DataDrake accepted this revision.Jan 14 2022, 5:44 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2022, 5:44 PM
DataDrake requested changes to this revision.Jan 14 2022, 5:46 PM

I know Yako is gone, but this needs to be rebased because of a missing commit so I'll look at it later

This revision now requires changes to proceed.Jan 14 2022, 5:46 PM
algent commandeered this revision.Mar 6 2022, 1:57 PM
algent added a reviewer: YakoYakoYokuYoku.
algent edited the summary of this revision. (Show Details)Mar 6 2022, 1:59 PM
algent removed a reviewer: YakoYakoYokuYoku.
algent removed subscribers: joebonrichie, JoshStrobl.
DataDrake accepted this revision.Mar 6 2022, 2:38 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 6 2022, 2:38 PM
This revision was automatically updated to reflect the committed changes.