Page MenuHomeSolus

racket: Update to 8.3
ClosedPublic

Authored by ermo on Mon, Nov 15, 10:06 AM.

Details

Summary

Bugfix and performance updates to Racket CS.

Changelogs:

Test Plan
  • Check that DrRacket can install packages
  • Check that DrRacket can load and run an example .rkt file
  • Check that the remacs editor project written in racket can be started from the command line

Diff Detail

Repository
R2779 racket
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ermo created this revision.Mon, Nov 15, 10:06 AM
ermo requested review of this revision.Mon, Nov 15, 10:06 AM
ermo edited the summary of this revision. (Show Details)Mon, Nov 15, 10:07 AM
JoshStrobl edited the summary of this revision. (Show Details)Tue, Nov 16, 6:44 AM
JoshStrobl requested changes to this revision.Tue, Nov 16, 6:48 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
16–17

Can be removed, gets pulled in by libgtk-3-devel

17–18

Can be removed, part of system.devel

18–19

Can be removed, gets pulled in by libgtk-3-devel

21

Doesn't need to be included, part of system.devel.

23–29

If it is no longer needed then we don't need to document its existence.

48

Should be next to libsplit not at the bottom

This revision now requires changes to proceed.Tue, Nov 16, 6:48 AM
ermo updated this revision to Diff 29920.Tue, Nov 16, 11:38 AM

Update per review.

ermo updated this revision to Diff 29921.Tue, Nov 16, 11:40 AM
ermo marked 2 inline comments as done.

Remove unnecessary deps.

ermo marked 4 inline comments as done.Tue, Nov 16, 11:41 AM

Diff pushed per review.

ermo added a comment.Tue, Nov 16, 12:05 PM

Turns out the removing pkgconfig(liblz4) was not a good idea. Adding it back in. Please hold off on landing it until I've updated the abi_* files.

ermo updated this revision to Diff 29922.Tue, Nov 16, 12:19 PM

Add back pkgconfig(liblz4) to deps.

ermo added a comment.Tue, Nov 16, 12:23 PM

There. Now things look (and work) like they should.

Was the removal of libjpeg-turbo-devel intentional? If not, it can be added back, but as pkgconfig(libturbojpeg)

ermo updated this revision to Diff 29929.Tue, Nov 16, 8:32 PM

Add back accidentally deleted libturbojpeg.

ermo added a comment.Tue, Nov 16, 8:33 PM

Was the removal of libjpeg-turbo-devel intentional? If not, it can be added back, but as pkgconfig(libturbojpeg)

No, unfortunately it wasn't. Thanks for catching it (oddly, there was no change to abi_*, but I just checked that the racket/draw package requires both libpng and libjpeg meaning that they're probably both DLOpen'ed) . Fixed now.

And thanks for the review. Apologies for the extra churn.

JoshStrobl accepted this revision.Fri, Nov 19, 6:50 AM

No problem, that's what the review process is for. LGTM, thanks!

This revision is now accepted and ready to land.Fri, Nov 19, 6:50 AM
This revision was automatically updated to reflect the committed changes.