Inclusion of Legendary Fixes T9305
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T9305: Legendary - Epic Games Launcher alternative
login, download a game, launch a game
Diff Detail
- Branch
- main
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 2433 Build 2433: arc lint + arc unit
Event Timeline
i've looked at their imports, and im still not sure what else it need other than python-requests
Hi @Meztli
You don't need python-setuptools here because at the moment in Solus this package contains only python2 modules and is used for building python2 packages, and setuptools for python3 is included in python3 package and therefore no need to specify builddeps here for legendary.
As I recommended you in your forum post, last 7 lines shoud be:
rundeps :
- python-requests
- python-wheel # to stop pip3 check complaining
build : |
%python3_setup
install : |
%python3_installpython-wheel is required optionally for setup/building. Maybe a better way is to patch setup.py file and remove this line.
i removed the builddeps and added python-wheels to rundeps and build it and it works, but is that all the rundeps it needs, from looking at their import its using the zlib module, should i add zlib as a builddep?
should i add zlib as a builddep?
Not necessary , zlib is part of system.base component.