Page MenuHomeSolus

Inclusion of Legendary Fixes T9305
Needs RevisionPublic

Authored by Meztli on Fri, Nov 12, 4:27 AM.

Details

Summary

Inclusion of Legendary Fixes T9305

Test Plan

login, download a game, launch a game

Diff Detail

Branch
main
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2433
Build 2433: arc lint + arc unit

Event Timeline

Meztli created this revision.Fri, Nov 12, 4:27 AM
Meztli requested review of this revision.Fri, Nov 12, 4:27 AM
JoshStrobl requested changes to this revision.Fri, Nov 12, 5:52 AM
JoshStrobl added a subscriber: JoshStrobl.

You're missing a bunch of rundeps. I would suggest taking a look at their imports.

package.yml
12

Use only 4 spaces.

13

Use only 4 spaces.

15

Use only 4 spaces.

This revision now requires changes to proceed.Fri, Nov 12, 5:52 AM

You're missing a bunch of rundeps. I would suggest taking a look at their imports.

i've looked at their imports, and im still not sure what else it need other than python-requests

algent added a subscriber: algent.Fri, Nov 12, 8:25 AM

Hi @Meztli
You don't need python-setuptools here because at the moment in Solus this package contains only python2 modules and is used for building python2 packages, and setuptools for python3 is included in python3 package and therefore no need to specify builddeps here for legendary.
As I recommended you in your forum post, last 7 lines shoud be:

rundeps    :
    - python-requests
    - python-wheel  # to stop pip3 check complaining
build      : |
    %python3_setup
install    : |
    %python3_install

python-wheel is required optionally for setup/building. Maybe a better way is to patch setup.py file and remove this line.

Hi @Meztli
You don't need python-setuptools here because at the moment in Solus this package contains only python2 modules and is used for building python2 packages, and setuptools for python3 is included in python3 package and therefore no need to specify builddeps here for legendary.
As I recommended you in your forum post, last 7 lines shoud be:

rundeps    :
    - python-requests
    - python-wheel  # to stop pip3 check complaining
build      : |
    %python3_setup
install    : |
    %python3_install

python-wheel is required optionally for setup/building. Maybe a better way is to patch setup.py file and remove this line.

i removed the builddeps and added python-wheels to rundeps and build it and it works, but is that all the rundeps it needs, from looking at their import its using the zlib module, should i add zlib as a builddep?

should i add zlib as a builddep?

Not necessary , zlib is part of system.base component.

should i add zlib as a builddep?

Not necessary , zlib is part of system.base component.

ok, so that should be it, right?