yabi: Ignore ELF files with .go suffix built by Guile >=2.2 JIT
ClosedPublic
Actions

Authored by ermo on Nov 9 2021, 11:49 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

rCOMNcf1b0b62e467: yabi: Ignore ELF files with .go suffix built by Guile >=2.2 JIT

Summary

Before:

[Package] Creating /home/build/work/guile-3.0.7-10-1-x86_64.eopkg ...
[History] Constructing new history entry
[Package] Building complete
INFO[11:21:47] Building succeeded                           
make[1]: Leaving directory '/home/ermo/solus-packages/guile'
make abireport
make[1]: Entering directory '/home/ermo/solus-packages/guile'
"../."/common/Go/yabi/yabi *.eopkg
 ⮞  Scanning 'guile-3.0.7-10-1-x86_64.eopkg'...
 ?  Failed to add file 'usr/lib64/guile/3.0/ccache/ice-9/and-let-star.go', reason: no symbol section
make[1]: *** [../Makefile.common:15: abireport] Error 1
make[1]: Leaving directory '/home/ermo/solus-packages/guile'
make: *** [../Makefile.common:12: complete] Error 2

After:

The make abireport target works as expected:

$ make abireport
"../."/common/Go/yabi/yabi *.eopkg
 ⮞  Scanning 'guile-3.0.7-10-1-x86_64.eopkg'...
 ?  Done
 ⮞  Scanning 'guile-32bit-3.0.7-10-1-x86_64.eopkg'...
 ?  Done
 ⮞  Scanning 'guile-32bit-devel-3.0.7-10-1-x86_64.eopkg'...
 ?  Done
 ⮞  Scanning 'guile-devel-3.0.7-10-1-x86_64.eopkg'...
 ?  Done

I can't see this impacting Go source files (foo.go) in any appreciable way, so I think the simple glob match should be sufficient for what I'm trying to achieve here.

Test Plan

Tested against local Guile 2.2.7 and 3.0.7 .eopkg builds and no longer breaks the make abireport target with this patch applied.

Diff Detail

Repository

rCOMN common

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ermo created this revision.Nov 9 2021, 11:49 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 9 2021, 11:49 AM

ermo requested review of this revision.Nov 9 2021, 11:49 AM

Harbormaster completed remote builds in B2350: Diff 29728.Nov 9 2021, 11:49 AM

ermo edited the summary of this revision. (Show Details)Nov 9 2021, 11:53 AM

ermo edited the summary of this revision. (Show Details)Nov 9 2021, 12:15 PM

ermo edited the summary of this revision. (Show Details)

ermo retitled this revision from yabi: Ignore ELF files with .go suffix built by Guile 3.0 JIT to yabi: Ignore ELF files with .go suffix built by Guile >=2.2 JIT.Nov 9 2021, 4:18 PM

ermo edited the test plan for this revision. (Show Details)