Page MenuHomeSolus
Differential D12190

Update rinutils to 0.10.0
ClosedPublic
Actions

Authored by Staudey on Nov 4 2021, 11:14 PM.
Tags
None
Referenced Files
F11020591: D12190.id29593.diff
Mon, Aug 7, 7:11 AM
F10948124: D12190.id29860.diff
Sat, Jul 15, 7:35 PM
F10947557: D12190.id29847.diff
Sat, Jul 15, 4:18 PM
F10865677: D12190.id29847.diff
Jun 17 2023, 12:29 PM
F10865614: D12190.id29593.diff
Jun 17 2023, 12:19 PM
F10862965: D12190.id29860.diff
Jun 16 2023, 11:55 PM
F10856932: D12190.diff
Jun 15 2023, 2:31 AM
F10780018: D12190.id.diff
May 24 2023, 9:55 PM
View All 10 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R4883:b7ba71b6c80c: Update rinutils to 0.10.0
Summary

Update rinutils to 0.10.0

Changes:

  • Fix the filenames in the comments of **.h and add SPDX identifiers
  • Add -DINSTALL_TO_DATADIR=…​ in CMakeLists.txt
  • Made the WITH_TEST_SUITE option off by default to avoid depending on cmocka
  • Convert the cmake build sys to INCLUDE(GNUInstallDirs)
  • Remove unused code and other cleanups
Test Plan

Built freecell-solver against this version

Diff Detail

Repository
R4883 rinutils
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Staudey created this revision.Nov 4 2021, 11:14 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptNov 4 2021, 11:14 PM
Staudey requested review of this revision.Nov 4 2021, 11:14 PM
Harbormaster completed remote builds in B2265: Diff 29593.Nov 4 2021, 11:14 PM
Staudey added a child revision: D12191: Update freecell-solver to 6.6.0.Nov 4 2021, 11:19 PM
JoshStrobl requested changes to this revision.Nov 11 2021, 11:32 AM
JoshStrobl added a subscriber: JoshStrobl.

We could just clean it up to be /* as the pattern then we don't have to think about updating the pattern going forward.

This revision now requires changes to proceed.Nov 11 2021, 11:32 AM
Staudey added a comment.Nov 11 2021, 12:44 PM

That makes sense. Will update when I get home.

Staudey updated this revision to Diff 29847.Nov 11 2021, 6:07 PM

Simplify pattern

Harbormaster completed remote builds in B2426: Diff 29847.Nov 11 2021, 6:07 PM
JoshStrobl accepted this revision.Nov 12 2021, 11:36 AM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 12 2021, 11:36 AM
Closed by commit R4883:b7ba71b6c80c: Update rinutils to 0.10.0 (authored by Staudey, committed by JoshStrobl). · Explain WhyNov 12 2021, 11:39 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R4883:b7ba71b6c80c: Update rinutils to 0.10.0.

Revision Contents
Changeset List

PathSize
11 lines
20 lines

Diff 29860

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.