Page MenuHomeSolus

Include a patch fixing a known issue
Needs RevisionPublic

Authored by solene on Nov 2 2021, 6:03 PM.

Details

Reviewers
JoshStrobl
kyrios123
Group Reviewers
Triage Team
Summary

Some package may fail compiling because of a change in libboost, it's a known issue and upstream provides a fix that this commit includes. See https://www.boost.org/users/history/version_1_72_0.html

Required for D12172

Test Plan

Compiling an update of package wesnoth that was failing without the patch

Diff Detail

Repository
R444 libboost
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2233
Build 2233: arc lint + arc unit

Event Timeline

solene created this revision.Nov 2 2021, 6:03 PM
solene requested review of this revision.Nov 2 2021, 6:03 PM
JoshStrobl requested changes to this revision.Nov 2 2021, 6:21 PM
JoshStrobl added a subscriber: JoshStrobl.
  1. No 80 column wrapping
  2. Don't use 4 space indent it treats it like code blocks
  3. Please link the issue referenced in the changelog.
This revision now requires changes to proceed.Nov 2 2021, 6:21 PM
solene edited the summary of this revision. (Show Details)Nov 2 2021, 8:42 PM
solene edited the test plan for this revision. (Show Details)
solene edited the test plan for this revision. (Show Details)
solene requested review of this revision.Nov 2 2021, 9:00 PM

I think I fixed all what was pointed out

kyrios123 requested changes to this revision.EditedNov 2 2021, 9:09 PM
kyrios123 added a subscriber: kyrios123.

The keyword fixes can only be used with tasks (Txxxxx) (i.e.: an issue or a request raised by a user), not with another differential (Dxxxxx).
Also you only need to specify the task reference Txxxxx, not a hyperlink to the task.

This revision now requires changes to proceed.Nov 2 2021, 9:09 PM
solene requested review of this revision.Nov 2 2021, 9:13 PM
solene edited the summary of this revision. (Show Details)

Understood, is it better with wording Required for ?

JoshStrobl edited the summary of this revision. (Show Details)Tue, Nov 9, 7:02 AM

Not sure the drop of numpy27 support is intended. Prodding @joebonrichie since he made changes related to splitting numpy 2.7. support into python2-numpy.

Please add python2-numpy to builddeps to readd python2 numpy support. This was overlooked by me when splitting numpy and updating the py3 version. Me and algent will look whether can be dropped subsequentially.

JoshStrobl requested changes to this revision.Tue, Nov 16, 12:38 PM

Yea figured as much.

This revision now requires changes to proceed.Tue, Nov 16, 12:38 PM