Include a patch fixing a known issue
AbandonedPublic
Actions

Authored by solene on Nov 2 2021, 6:03 PM.

Details

Reviewers

JoshStrobl
kyrios123

Group Reviewers

Triage Team

Summary

Some package may fail compiling because of a change in libboost, it's a known issue and upstream provides a fix that this commit includes. See https://www.boost.org/users/history/version_1_72_0.html

Required for D12172

Test Plan

Compiling an update of package wesnoth that was failing without the patch

Diff Detail

Repository

R444 libboost

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 2233
Build 2233: arc lint + arc unit

Event Timeline

solene created this revision.Nov 2 2021, 6:03 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 2 2021, 6:03 PM

solene requested review of this revision.Nov 2 2021, 6:03 PM

Harbormaster completed remote builds in B2233: Diff 29548.Nov 2 2021, 6:03 PM

solene mentioned this in D12172: Update wesnoth to 1.16.0.Nov 2 2021, 6:13 PM

No 80 column wrapping
Don't use 4 space indent it treats it like code blocks
Please link the issue referenced in the changelog.

This revision now requires changes to proceed.Nov 2 2021, 6:21 PM

solene edited the summary of this revision. (Show Details)Nov 2 2021, 8:42 PM

solene edited the test plan for this revision. (Show Details)

solene added a child revision: D12172: Update wesnoth to 1.16.0.Nov 2 2021, 8:44 PM

I think I fixed all what was pointed out

The keyword fixes can only be used with tasks (Txxxxx) (i.e.: an issue or a request raised by a user), not with another differential (Dxxxxx).
Also you only need to specify the task reference Txxxxx, not a hyperlink to the task.

This revision now requires changes to proceed.Nov 2 2021, 9:09 PM

Understood, is it better with wording Required for ?

JoshStrobl edited the summary of this revision. (Show Details)Nov 9 2021, 7:02 AM

Not sure the drop of numpy27 support is intended. Prodding @joebonrichie since he made changes related to splitting numpy 2.7. support into python2-numpy.

Please add python2-numpy to builddeps to readd python2 numpy support. This was overlooked by me when splitting numpy and updating the py3 version. Me and algent will look whether can be dropped subsequentially.