Details
- Reviewers
Girtablulu - Group Reviewers
Triage Team - Maniphest Tasks
- T9924: ProtonVPN GUI
- Commits
- R5438:913010fb00e1: Initial commit for protonvpn-gui, version 1.4.1
Connected to various locations around the world, ran speed and leak
test, and verified log generation and tray icon behavior.
Signed-off-by: Gavin Zhao <gavinzhaojw@protonmail.com>
Diff Detail
- Repository
- R5438 protonvpn-gui
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
builddeps should be cleaned up. If it isn't needed during build time, it shouldn't be added (e.g. a bunch of rundeps not needed during build)
| package.yml | ||
|---|---|---|
| 14 | You're already pulling in libwebkit-gtk-devel so this isn't needed. | |
| 58 | Can just be install -Dm00644 protonvpn.desktop $installdir/usr/share/applications/protonvpn.desktop | |
| 62 | Same here re. install | |
Understood. I'm also doing some refactoring with the Proton Python Client and the ProtonVPN Network Manager library. Before they were packaged into protonvpn-cli, but now since we have two packages using them the versioning and dependencies start to get messy, so I'll separate these two and update everything together.
last thing the rest looks good :)
| package.yml | ||
|---|---|---|
| 7 | needs to be SPDX confrom https://spdx.org/licenses/preview/ | |