Page MenuHomeSolus

Initial commit for protonvpn-gui, version 1.4.1
ClosedPublic

Authored by GZGavinZhao on Oct 27 2021, 12:11 AM.

Details

Summary

Resolves T9924.

Depends on D12061, D12679, D12680.

Test Plan

Connected to various locations around the world, ran speed and leak
test, and verified log generation and tray icon behavior.

Signed-off-by: Gavin Zhao <gavinzhaojw@protonmail.com>

Diff Detail

Repository
R5438 protonvpn-gui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

GZGavinZhao created this revision.Oct 27 2021, 12:11 AM
GZGavinZhao requested review of this revision.Oct 27 2021, 12:11 AM
jppelt added a subscriber: jppelt.Nov 18 2021, 4:44 AM
JoshStrobl requested changes to this revision.Dec 25 2021, 10:22 AM
JoshStrobl added a subscriber: JoshStrobl.

builddeps should be cleaned up. If it isn't needed during build time, it shouldn't be added (e.g. a bunch of rundeps not needed during build)

package.yml
14

You're already pulling in libwebkit-gtk-devel so this isn't needed.

58

Can just be install -Dm00644 protonvpn.desktop $installdir/usr/share/applications/protonvpn.desktop

62

Same here re. install

This revision now requires changes to proceed.Dec 25 2021, 10:22 AM

Understood. I'm also doing some refactoring with the Proton Python Client and the ProtonVPN Network Manager library. Before they were packaged into protonvpn-cli, but now since we have two packages using them the versioning and dependencies start to get messy, so I'll separate these two and update everything together.

Fix requested changes and refactor.

GZGavinZhao marked 3 inline comments as done.

Update MAINTAINERS file.

Girtablulu removed a subscriber: JoshStrobl.
Girtablulu requested changes to this revision.Tue, Jan 18, 9:54 PM
Girtablulu added a subscriber: Girtablulu.

last thing the rest looks good :)

package.yml
7

needs to be SPDX confrom https://spdx.org/licenses/preview/

This revision now requires changes to proceed.Tue, Jan 18, 9:54 PM

Fix requested changes.

Girtablulu accepted this revision.Tue, Jan 18, 10:40 PM

LGTM, thx

This revision is now accepted and ready to land.Tue, Jan 18, 10:40 PM
This revision was automatically updated to reflect the committed changes.