Paths

Table of Contentst

Differential D12090

Initial commit of libtpms
ClosedPublic
Actions

Authored by Jacek on Oct 24 2021, 1:35 PM.

Tags

None

Referenced Files

	F11071099: D12090.id31224.diff
	Sat, Aug 12, 1:05 AM

	F11071098: D12090.id31141.diff
	Sat, Aug 12, 1:05 AM

	F11071097: D12090.id.diff
	Sat, Aug 12, 1:05 AM

	F11052849: D12090.diff
	Thu, Aug 10, 10:12 PM

	F11020429: D12090.id29367.diff
	Mon, Aug 7, 5:07 AM

	F11015878: D12090.diff
	Sat, Aug 5, 2:51 PM

	F10937006: D12090.id31224.diff
	Thu, Jul 13, 5:36 AM

	F10882911: D12090.id.diff
	Jun 23 2023, 8:37 PM

View All 17 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R5457:9756ad6bc708: Initial commit of libtpms

Summary

Test Plan

Tested with swtpm in virt-manager

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 2097
Build 2097: arc lint + arc unit

Event Timeline

Jacek created this revision.Oct 24 2021, 1:35 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 24 2021, 1:35 PM

Harbormaster completed remote builds in B2097: Diff 29367.Oct 24 2021, 1:35 PM

Jacek requested review of this revision.Oct 24 2021, 1:35 PM

Jacek added a child revision: D12089: Initial commit of swtpm.Nov 11 2021, 10:47 PM

JoshStrobl requested changes to this revision.Dec 25 2021, 10:15 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
6	It isn't OpenMPI as it doesn't have the same clauses / structure. Fedora considers it to be BSD-3-Clause + "TCGL" since it is based around BSD. So a list would work better: license : - BSD-3-Clause - TCGL
14	Should be able to just do `%reconfigure` and skip the `NOCONFIGURE=1 and autogen`
pspec_x86_64.xml
68	Disable static lib

This revision now requires changes to proceed.Dec 25 2021, 10:15 AM

Closing due to lack of movement in over 30 days.

Fix license, NOCONFIGURE and static library

Harbormaster completed remote builds in B3177: Diff 31141.Jan 27 2022, 1:59 PM

I am really sorry it took me so long to fix it, I am struggling with at my university and didn't have time.

LGTM, thx

This revision is now accepted and ready to land.Feb 2 2022, 8:59 AM

Closed by commit R5457:9756ad6bc708: Initial commit of libtpms (authored by Jacek, committed by Girtablulu). · Explain WhyFeb 2 2022, 9:08 AM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5457:9756ad6bc708: Initial commit of libtpms.

Revision Contents
Changeset List

Path

Size

1 line

1 line

28 lines

2 lines

abi_used_symbols

206 lines

18 lines

pspec_x86_64.xml

82 lines

Diff 29367

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...