Paths

Table of Contentst

Differential D12089

Initial commit of swtpm
ClosedPublic
Actions

Authored by Jacek on Oct 24 2021, 1:34 PM.

Tags

None

Referenced Files

	F11052897: D12089.id.diff
	Thu, Aug 10, 10:15 PM

	F11052896: D12089.id29366.diff
	Thu, Aug 10, 10:15 PM

	F11052895: D12089.id31142.diff
	Thu, Aug 10, 10:15 PM

	F11052894: D12089.id31226.diff
	Thu, Aug 10, 10:15 PM

	F11037499: D12089.diff
	Wed, Aug 9, 8:43 PM

	F10971932: D12089.id.diff
	Fri, Jul 21, 9:29 AM

	F10903447: D12089.id31142.diff
	Jul 5 2023, 12:57 PM

	F10895472: D12089.id.diff
	Jul 1 2023, 5:08 PM

View All 14 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R5459:dfdf7df44186: Initial commit of swtpm

Summary

Solves T9964. Depends on D12090

Test Plan

Added TPM 2.0 in virt-manager successfully, verified it works in a Windows 11 VM.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Jacek created this revision.Oct 24 2021, 1:34 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 24 2021, 1:34 PM

Jacek requested review of this revision.Oct 24 2021, 1:34 PM

Harbormaster completed remote builds in B2096: Diff 29366.Oct 24 2021, 1:34 PM

Jacek mentioned this in D12090: Initial commit of libtpms.Oct 24 2021, 1:35 PM

There are 2 things I am not sure enough:

component: virt - choosed it because qemu uses it, but it is not on the list of eopkg lc. Not sure if that is alright, or I should choose something else
Is using NOCONFIGURE=1 for %autogen alright, or should I just pass %configure parameters to autogen?

You should add to summary Depends on D12090. pkgconfig(libtpms) is not yet available in the repo.

algent removed a subscriber: algent.Nov 11 2021, 5:13 PM

Jacek edited the summary of this revision. (Show Details)Nov 11 2021, 10:47 PM

Jacek added a parent revision: D12090: Initial commit of libtpms.

JoshStrobl requested changes to this revision.Dec 25 2021, 10:17 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
7	See libtpms feedback on this stage.
26	See libtpms feedback on this stage.

This revision now requires changes to proceed.Dec 25 2021, 10:17 AM

Closing due to lack of movement in over 30 days.

Fix license, NOCONFIGURE and static library

Harbormaster completed remote builds in B3178: Diff 31142.Jan 27 2022, 2:01 PM

LGTM, thx

This revision is now accepted and ready to land.Feb 2 2022, 9:00 AM

Girtablulu mentioned this in R5457:9756ad6bc708: Initial commit of libtpms.Feb 2 2022, 9:08 AM

Closed by commit R5459:dfdf7df44186: Initial commit of swtpm (authored by Jacek, committed by Girtablulu). · Explain WhyFeb 2 2022, 9:11 AM

This revision was automatically updated to reflect the committed changes.

Girtablulu added a commit: R5459:dfdf7df44186: Initial commit of swtpm.

Revision Contents
Changeset List

Path

Size

1 line

1 line

116 lines

11 lines

abi_used_symbols

290 lines

29 lines

pspec_x86_64.xml

76 lines

Diff 31226

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...