Page MenuHomeSolus

Initial inclusion of davmail
ClosedPublic

Authored by alexanderzhirov on Oct 21 2021, 6:06 AM.

Details

Summary

DavMail allowing users to use any mail/calendar client with an Exchange server. Resolves T2050

Test Plan

Tested with Remote Exchange Server and Thunderbird

Diff Detail

Repository
R5343 davmail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alexanderzhirov requested review of this revision.Oct 21 2021, 6:06 AM
JoshStrobl requested changes to this revision.Oct 21 2021, 3:25 PM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a task: T2050: Davmail.
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
12–13

Should just be homepage : URL

17

Requires OpenJDK 8 but also needs ant that is OpenJDK 11?=

24

Nope nope nope nope nope. Needs to be put into proper directors not opt.

This revision now requires changes to proceed.Oct 21 2021, 3:27 PM
alexanderzhirov retitled this revision from Initial commit of davmail to Changed the installation path and fixed the homepage url.

Changed the installation path and fixed the homepage url

alexanderzhirov marked 3 inline comments as done.Oct 21 2021, 4:14 PM

@JoshStrobl Basically, it works under OpenJDK-11, but builds with a warning. And if you build from OpenJDK-8, but run from OpenJDK-11? Or does it sound completely crazy?

package.yml
17

When building a project under openjdk-11, an error occurs that is missing when building through openjdk-8. That's why I decided to use it.

24

There the standard installation is in /usr/share/davmail, then I'll leave it there.

kyrios123 added inline comments.
package.yml
7

license is GPL-2.0-or-later

alexanderzhirov updated this revision to Diff 29337.EditedOct 21 2021, 11:28 PM
alexanderzhirov marked 2 inline comments as done.
alexanderzhirov retitled this revision from Changed the installation path and fixed the homepage url to editing package assembly.

Initial inclusion of davmail

alexanderzhirov retitled this revision from editing package assembly to Initial inclusion of davmail.Oct 22 2021, 6:57 AM
alexanderzhirov marked an inline comment as done.

Using openjdk-11

alexanderzhirov added a comment.EditedOct 22 2021, 3:25 PM

Got a response from the developer that the warnings when building a project using OpenJDK-11 are not errors. Corrected the assembly file with use OpenJDK-11.

JoshStrobl requested changes to this revision.Oct 22 2021, 5:40 PM

Otherwise LGTM :) I mean it *is* Java so it can only look so good.

MAINTAINERS.md
4

This shouldn't be indented. Please refrain from making any modifications to the indentation.

This revision now requires changes to proceed.Oct 22 2021, 5:40 PM

fix MAINTAINSER.md

Sorry, missed during review.

package.yml
17

Part of system.base so doesn't need to be specified.

JoshStrobl requested changes to this revision.Nov 9 2021, 7:16 AM
This revision now requires changes to proceed.Nov 9 2021, 7:16 AM
alexanderzhirov updated this revision to Diff 29729.EditedNov 9 2021, 1:47 PM
alexanderzhirov marked an inline comment as done.

Delete unzip

JoshStrobl accepted this revision.Nov 11 2021, 11:24 AM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 11 2021, 11:24 AM
This revision was automatically updated to reflect the committed changes.