Paths

Table of Contentst

Differential D12048

pipewire: put ALSA configs in dir where they are actually picked up
ClosedPublic
Actions

Authored by Staudey on Oct 17 2021, 5:48 PM.

Tags

None

Referenced Files

	F10774206: D12048.id29286.diff
	Mon, May 22, 4:06 AM

	F10719514: D12048.id.diff
	Fri, May 5, 10:47 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R4226:cbaa8679b702: pipewire: put ALSA configs in dir where they are actually picked up

Summary

pipewire: put ALSA configs in dir where they are actually picked up

Fixes issues with e.g. fmod games on Steam, see here

Depends on D12037

Test Plan

Played Project Zomboid with pipewire and sound

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Staudey created this revision.Oct 17 2021, 5:48 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 17 2021, 5:48 PM

Staudey requested review of this revision.Oct 17 2021, 5:48 PM

Harbormaster completed remote builds in B2033: Diff 29260.Oct 17 2021, 5:48 PM

livingsilver94 added a subscriber: livingsilver94.Oct 18 2021, 10:31 AM

livingsilver94 added inline comments.

package.yml
53	I know I'm being pedantic, but IMO slashes as separators in the sed syntax should be avoided. They often get confused with path separators. Pipes, or hash signs, or colons are more suitable characters (`\|`, `#`, `:`).

@livingsilver: I have no strong opinion on this, and can change it if you think it would be best. I just usually use slashes.

Seems legit otherwise ?

package.yml
53	Agreed, would prefer `:` but I too am pedantic.

This revision now requires changes to proceed.Oct 18 2021, 4:32 PM

Use less ambiguous separators for sed

Harbormaster completed remote builds in B2046: Diff 29273.Oct 18 2021, 5:03 PM

but I too am pedantic

You don't say ?

You could still do with the single quotes around the string

Update sed command yet again

Harbormaster completed remote builds in B2048: Diff 29286.Oct 18 2021, 5:30 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 18 2021, 5:43 PM

Closed by commit R4226:cbaa8679b702: pipewire: put ALSA configs in dir where they are actually picked up (authored by Staudey, committed by JoshStrobl). · Explain WhyOct 18 2021, 5:48 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4226:cbaa8679b702: pipewire: put ALSA configs in dir where they are actually picked up.

Revision Contents
Changeset List

Path

Size

3 lines

pspec_x86_64.xml

18 lines

Diff 29288

package.yml

Loading...

pspec_x86_64.xml

Loading...