Page MenuHomeSolus

pipewire: put ALSA configs in dir where they are actually picked up
ClosedPublic

Authored by Staudey on Oct 17 2021, 5:48 PM.

Details

Summary

pipewire: put ALSA configs in dir where they are actually picked up

Fixes issues with e.g. fmod games on Steam, see here

Depends on D12037

Test Plan

Played Project Zomboid with pipewire and sound

Diff Detail

Repository
R4226 pipewire
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Oct 17 2021, 5:48 PM
Staudey requested review of this revision.Oct 17 2021, 5:48 PM
livingsilver94 added inline comments.
package.yml
53

I know I'm being pedantic, but IMO slashes as separators in the sed syntax should be avoided. They often get confused with path separators. Pipes, or hash signs, or colons are more suitable characters (|, #, :).

@livingsilver: I have no strong opinion on this, and can change it if you think it would be best. I just usually use slashes.

JoshStrobl requested changes to this revision.Oct 18 2021, 4:32 PM
JoshStrobl added a subscriber: JoshStrobl.

Seems legit otherwise ๐Ÿ‘

package.yml
53

Agreed, would prefer : but I too am pedantic.

This revision now requires changes to proceed.Oct 18 2021, 4:32 PM
Staudey updated this revision to Diff 29273.Oct 18 2021, 5:03 PM

Use less ambiguous separators for sed

Staudey marked 2 inline comments as done.Oct 18 2021, 5:03 PM

but I too am pedantic

You don't say ๐Ÿ˜œ

You could still do with the single quotes around the string

Staudey updated this revision to Diff 29286.Oct 18 2021, 5:30 PM

Update sed command yet again

JoshStrobl accepted this revision.Oct 18 2021, 5:43 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 18 2021, 5:43 PM