Page MenuHomeSolus

Initial inclusion of nanorc
ClosedPublic

Authored by abdulocracy on Oct 14 2021, 11:26 AM.

Details

Summary

Contains the scopatz nanorc files, new dependency of nano.

Test Plan

Edit .conf file with nano and see if trailing spaces are highlighted green.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2017
Build 2017: arc lint + arc unit

Event Timeline

abdulocracy created this revision.Oct 14 2021, 11:26 AM
abdulocracy requested review of this revision.Oct 14 2021, 11:26 AM
JoshStrobl requested changes to this revision.Oct 15 2021, 9:40 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
11

Let's just do: Package with language-specific nanorc files [...]

13

Use install instead

This revision now requires changes to proceed.Oct 15 2021, 9:40 AM

Replace mkdir with install.

abdulocracy marked 2 inline comments as done.Oct 15 2021, 10:55 AM
JoshStrobl requested changes to this revision.Oct 15 2021, 11:27 AM
JoshStrobl added inline comments.
package.yml
13

Should be 00644

This revision now requires changes to proceed.Oct 15 2021, 11:27 AM
abdulocracy added inline comments.Oct 15 2021, 1:33 PM
package.yml
13

It's a directory, so 755 I think.

Fix directory permissions.

DataDrake requested changes to this revision.Oct 16 2021, 1:17 AM
DataDrake added a subscriber: DataDrake.

The name of this package should be nanorc to match the upstream repo.

This revision now requires changes to proceed.Oct 16 2021, 1:17 AM

Should it? Perhaps something like scopatz-nanorc since nanorc by itself is generic. I understand sticking to the upstream name is important but in this case the upstream name isn't really a name.

I don't see how it isn't a name? It's a repo full of nanorc files. Arch is the only distro that currently ships these using that name and I don't agree with their decision.

@DataDrake does raise a good point that nano-syntax-highlighting is not the correct upstream name and we shouldn't be basing our package names around what other operating systems do. nanorc makes sense to me as well.

Change name.

abdulocracy retitled this revision from Initial inclusion of nano-syntax-highlighting to Initial inclusion of nanorc.Oct 16 2021, 8:35 PM
DataDrake accepted this revision.Jan 14 2022, 7:48 PM
DataDrake removed a reviewer: JoshStrobl.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2022, 7:48 PM
This revision was automatically updated to reflect the committed changes.