Differential D11940

Update mame to 0.236
ClosedPublic
Actions

Authored by livingsilver94 on Oct 3 2021, 10:09 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R3922:eca4c62c88cb: Update mame to 0.236

Summary

Changelog available here.

Packager notes:

Reduced installed size by ~20 MiB by enabling ICF linker flag.

Test Plan

Successfully played Fire One.

Diff Detail

Repository

R3922 mame

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1878
Build 1878: arc lint + arc unit

Event Timeline

livingsilver94 created this revision.Oct 3 2021, 10:09 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 3 2021, 10:09 AM

livingsilver94 requested review of this revision.Oct 3 2021, 10:09 AM

Harbormaster completed remote builds in B1878: Diff 29048.Oct 3 2021, 10:09 AM

I would be cautious about icf-all with the gold linker, I only feel confident with icf-all with llvm/lld. But as long as it's tested properly s'all good. As it's a end-user application that nothing links against I doubt there will be a problem in this particular case.

In D11940#200778, @joebonrichie wrote:

As it's a end-user application that nothing links against I doubt there will be a problem in this particular case.

That's the idea. It's a game application in the lowest level of a dependency tree, thus not critical. I took the safer route with Telegram as it's a chat application, in fact.