Page MenuHomeSolus

Update mame to 0.236
ClosedPublic

Authored by livingsilver94 on Sun, Oct 3, 10:09 AM.

Details

Summary

Changelog available here.

Packager notes:

  • Reduced installed size by ~20 MiB by enabling ICF linker flag.
Test Plan

Successfully played Fire One.

Diff Detail

Repository
R3922 mame
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Sun, Oct 3, 10:09 AM
livingsilver94 requested review of this revision.Sun, Oct 3, 10:09 AM

I would be cautious about icf-all with the gold linker, I only feel confident with icf-all with llvm/lld. But as long as it's tested properly s'all good. As it's a end-user application that nothing links against I doubt there will be a problem in this particular case.

As it's a end-user application that nothing links against I doubt there will be a problem in this particular case.

That's the idea. It's a game application in the lowest level of a dependency tree, thus not critical. I took the safer route with Telegram as it's a chat application, in fact.

JoshStrobl accepted this revision.Tue, Oct 5, 9:32 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Oct 5, 9:32 AM
This revision was automatically updated to reflect the committed changes.