Page MenuHomeSolus

Initial commit of qt6-base
ClosedPublic

Authored by YakoYakoYokuYoku on Oct 2 2021, 7:24 PM.

Details

Summary

Qt6 is gaining support on more software (including BeeRef, Poppler and Strawberry) and is now buildable than it was before at the time of this diff.

Depends on D11936 and D11937.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Built qtwebengine, pyside6 and pyqt6 against it, used qtwebengine to load the Linux website and beeref for dropping some pics on it.

Diff Detail

Repository
R5352 qt6-base
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Oct 2 2021, 7:24 PM
algent awarded a token.Oct 2 2021, 7:26 PM
Girtablulu requested changes to this revision.Oct 2 2021, 7:56 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
65

what following packages do need mesalib?

70

-DINSTALL_LIBDIR=%libdir% needs to be added as well

71

-DINSTALL_BINDIR=%libdir%/qt6/bin

73

this should be -DINSTALL_LIBEXECDIR=/usr/libexec/Qt6

unless the changed something with 6.2 which I haven't seen

75

-DINSTALL_ARCHDATADIR=%libdir%/qt6

78

-DINSTALL_MKSPECSDIR=%libdir%/qt6/mkspecs \

79

-DINSTALL_EXAMPLESDIR=%libdir%/qt6/examples

103

should - /usr/libexec/Qt6 should be added as well

pspec_x86_64.xml
145

doc should be patterned as well

This revision now requires changes to proceed.Oct 2 2021, 7:56 PM
YakoYakoYokuYoku marked 7 inline comments as done.

Fixed CMake installs.

package.yml
65

mesalib gets checked by Qt6 CMake IIRC, also qt5-base-devel does depend on it too

73

Prefered to use /usr/lib64/qt6 because libexec is not used by many packages and building plus using the software that depends on qtbase works correctly

103

Same as above

pspec_x86_64.xml
145

Dunno if I should put this in qt6-base-devel for qt6-doc consumption or in qt6-base-docs

algent added a subscriber: algent.Oct 3 2021, 4:16 PM

You can clean some deps here @YakoYakoYokuYoku

pkgconfig(xcb-icccm) - duplicated
pkgconfig(xcb-image)
pkgconfig(xcb-keysyms) - duplicated
pkgconfig(xcb-renderutil)
pkgconfig(xrender)

Deduplicate builddeps.

Update to 6.2.1.

Girtablulu accepted this revision.Nov 7 2021, 10:09 AM

LGTM, thx

This revision is now accepted and ready to land.Nov 7 2021, 10:09 AM

Generate pkgconfigs.

YakoYakoYokuYoku planned changes to this revision.Nov 9 2021, 10:02 PM

Tinker pkgconfig generation.

This revision is now accepted and ready to land.Nov 9 2021, 10:52 PM

Ship Library.pc.in template file.

Include checks for pkgconfig gen.

algent removed a subscriber: algent.Nov 11 2021, 5:11 PM

Generate include directories.

This revision was automatically updated to reflect the committed changes.