Page MenuHomeSolus

Initial commit of qt6-base
Needs ReviewPublic

Authored by YakoYakoYokuYoku on Sat, Oct 2, 7:24 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Summary

Qt6 is gaining support on more software (including BeeRef, Poppler and Strawberry) and is now buildable than it was before at the time of this diff.

Depends on D11936 and D11937.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Built qtwebengine, pyside6 and pyqt6 against it, used qtwebengine to load the Linux website and beeref for dropping some pics on it.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1925
Build 1925: arc lint + arc unit

Event Timeline

YakoYakoYokuYoku requested review of this revision.Sat, Oct 2, 7:24 PM
algent awarded a token.Sat, Oct 2, 7:26 PM
Girtablulu requested changes to this revision.Sat, Oct 2, 7:56 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
65

what following packages do need mesalib?

70

-DINSTALL_LIBDIR=%libdir% needs to be added as well

71

-DINSTALL_BINDIR=%libdir%/qt6/bin

73

this should be -DINSTALL_LIBEXECDIR=/usr/libexec/Qt6

unless the changed something with 6.2 which I haven't seen

75

-DINSTALL_ARCHDATADIR=%libdir%/qt6

78

-DINSTALL_MKSPECSDIR=%libdir%/qt6/mkspecs \

79

-DINSTALL_EXAMPLESDIR=%libdir%/qt6/examples

103

should - /usr/libexec/Qt6 should be added as well

pspec_x86_64.xml
145

doc should be patterned as well

This revision now requires changes to proceed.Sat, Oct 2, 7:56 PM
YakoYakoYokuYoku marked 7 inline comments as done.

Fixed CMake installs.

package.yml
65

mesalib gets checked by Qt6 CMake IIRC, also qt5-base-devel does depend on it too

73

Prefered to use /usr/lib64/qt6 because libexec is not used by many packages and building plus using the software that depends on qtbase works correctly

103

Same as above

pspec_x86_64.xml
145

Dunno if I should put this in qt6-base-devel for qt6-doc consumption or in qt6-base-docs

algent added a subscriber: algent.Sun, Oct 3, 4:16 PM

You can clean some deps here @YakoYakoYokuYoku

pkgconfig(xcb-icccm) - duplicated
pkgconfig(xcb-image)
pkgconfig(xcb-keysyms) - duplicated
pkgconfig(xcb-renderutil)
pkgconfig(xrender)

Deduplicate builddeps.