Paths

Table of Contentst

Differential D11900

Update to 3.3.4 and fix VFS
ClosedPublic
Actions

Authored by palto42 on Sep 24 2021, 4:30 PM.

Tags

None

Referenced Files

	F11004812: D11900.diff
	Tue, Aug 1, 3:38 AM

	F10942022: D11900.id.diff
	Fri, Jul 14, 9:02 AM

	F10897492: D11900.diff
	Jul 2 2023, 7:20 AM

	F10897352: D11900.id.diff
	Jul 2 2023, 6:07 AM

	F10893516: D11900.id28933.diff
	Jun 30 2023, 9:18 PM

	F10893493: D11900.id28933.diff
	Jun 30 2023, 8:52 PM

	F10873814: D11900.diff
	Jun 19 2023, 6:27 PM

	F10858305: D11900.id28932.diff
	Jun 15 2023, 2:47 PM

View All 19 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3740:0e9b170f51ca: Update to 3.3.4 and fix VFS

Summary

Changelog:

Fixed installation path of virtual file system modules (experimental feature)
Prevent infinte recursion when closing a websocket in case of SSL errors
Accept nc scheme in provider page

Signed-off-by: Matthias Homann <palto@mailbox.org>

Test Plan

Built and installed locally
Enabled experimental options in NC client config
Enabled and tested VFS for one sync

Diff Detail

Repository

R3740 nextcloud-client

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

palto42 created this revision.Sep 24 2021, 4:30 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 24 2021, 4:30 PM

Harbormaster completed remote builds in B1815: Diff 28932.Sep 24 2021, 4:30 PM

palto42 requested review of this revision.Sep 24 2021, 4:30 PM

removed obsolete command in install section (from testing)

Harbormaster completed remote builds in B1816: Diff 28933.Sep 24 2021, 4:33 PM

JoshStrobl requested changes to this revision.Sep 24 2021, 8:16 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
45–46	Unnecessarily verbose now. Should be reverted.
46	Unnecessarily verbose now. Should be reverted.

This revision now requires changes to proceed.Sep 24 2021, 8:16 PM

Hi @JoshStrobl,
I had to change the pattern of the dolphin-integration to ensure that the VFS plugins /usr/lib64/qt5/plugins/nextcloudsync_vfs_suffix.so and /usr/lib64/qt5/plugins/nextcloudsync_vfs_xattr.so are packaged with the main nextcloud-client. I tried some other wildcard match to only include *dolphin*, but it didn't work and I though it's not really worth the effort for just 2 files.
Please suggest a suitable wildcard if you still think that the explicit statements aren't suitable.

package.yml
45–46	This was done to avoid that the VFS plugins are packaged with the dolphin-integration instead of the main nextcloud-client package
46	This was done to avoid that the VFS plugins are packaged with the dolphin-integration instead of the main nextcloud-client package

Ah yea, I'm a pepega don't mind me.

This revision is now accepted and ready to land.Sep 27 2021, 5:00 PM

Closed by commit R3740:0e9b170f51ca: Update to 3.3.4 and fix VFS (authored by palto42, committed by JoshStrobl). · Explain WhySep 27 2021, 5:01 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R3740:0e9b170f51ca: Update to 3.3.4 and fix VFS.

Revision Contents
Changeset List

Path

Size

15 lines

pspec_x86_64.xml

18 lines

Diff 28963

package.yml

Loading...

pspec_x86_64.xml

Loading...