Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T9768: Clojure

Commits

R5349:516bb7602387: The inclusion of clojure-tools

Summary

Inclusion of clojure tools for clojure development

Fixes T9768

Test Plan

I ran these steps
make followed by solbuild to make the eopkg file, then I ran eopkg install on the resulting file.
I then ran clj --version to check the version and clj to make sure teh interactive repl launched

Diff Detail

Repository

R5349 clojure-tools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

oly created this revision.Sep 17 2021, 6:06 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 17 2021, 6:06 PM

Harbormaster completed remote builds in B1771: Diff 28859.Sep 17 2021, 6:06 PM

oly requested review of this revision.Sep 17 2021, 6:06 PM

You should be generated the YAML per https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

Also why isn't this being built from source?

package.yml
7	Invalid license.
17	Should be removed

This revision now requires changes to proceed.Sep 17 2021, 6:12 PM

JoshStrobl added inline comments.Sep 17 2021, 6:13 PM

package.yml
8	Our components are lowercased. See `eopkg lc`
14	Should be indented by 4 spaces

Resolving indentation, removed ls, lowercase category and changed license
I will see about building from source

Harbormaster completed remote builds in B1772: Diff 28860.Sep 17 2021, 6:23 PM

Indented by 4, lowercased category, changed license and remove ls line.

Harbormaster completed remote builds in B1773: Diff 28861.Sep 17 2021, 6:24 PM

Seems I had not amended my most recent changes.

Harbormaster completed remote builds in B1774: Diff 28862.Sep 17 2021, 6:28 PM

Third times a charm hopefully.

Harbormaster completed remote builds in B1775: Diff 28863.Sep 17 2021, 6:31 PM

Minor changes from comment in chat mainly adding 00 in front of the perms and reverting the package file

Harbormaster completed remote builds in B1785: Diff 28874.Sep 19 2021, 6:41 PM

Okay you asked why this is not built from source, this is a little complicated the source does not really need building, ci basically copies these files and adds a jar which is not included in the src repo.
I looked into building this ja from source and injecting but it seems to be a catch 22 in that you need clojure build tools to make the jar but as these do not exist in the repo this seems impractical.
In this situation is it okay to include or would another work around be required ?

Thanks for the clarification. Still need to see the issues I raised (like properly generating the package.yml, I can tell it isn't since the alignment is off). Let's get this set to programming.tools component as well.

This revision now requires changes to proceed.Sep 27 2021, 10:14 PM

Generated package.yaml and copied values over, changed to tag as programming.tools

Harbormaster completed remote builds in B1849: Diff 29008.Sep 28 2021, 6:16 PM

Anything left still blocking this package ? I want to package some other apps but am awaiting the inclusion of this one

Updated to latest clojure version

Harbormaster completed remote builds in B2435: Diff 29873.Nov 12 2021, 1:54 PM