Page MenuHomeSolus

The inclusion of clojure-tools
ClosedPublic

Authored by oly on Sep 17 2021, 6:06 PM.

Details

Summary

Inclusion of clojure tools for clojure development

Fixes T9768

Test Plan

I ran these steps
make followed by solbuild to make the eopkg file, then I ran eopkg install on the resulting file.
I then ran clj --version to check the version and clj to make sure teh interactive repl launched

Diff Detail

Repository
R5349 clojure-tools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

oly created this revision.Sep 17 2021, 6:06 PM
oly requested review of this revision.Sep 17 2021, 6:06 PM
JoshStrobl requested changes to this revision.Sep 17 2021, 6:12 PM
JoshStrobl added a subscriber: JoshStrobl.

You should be generated the YAML per https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

Also why isn't this being built from source?

package.yml
7

Invalid license.

17

Should be removed

This revision now requires changes to proceed.Sep 17 2021, 6:12 PM
JoshStrobl added inline comments.Sep 17 2021, 6:13 PM
package.yml
8

Our components are lowercased. See eopkg lc

14

Should be indented by 4 spaces

oly updated this revision to Diff 28860.Sep 17 2021, 6:23 PM

Resolving indentation, removed ls, lowercase category and changed license
I will see about building from source

oly updated this revision to Diff 28861.Sep 17 2021, 6:24 PM

Indented by 4, lowercased category, changed license and remove ls line.

oly updated this revision to Diff 28862.Sep 17 2021, 6:28 PM

Seems I had not amended my most recent changes.

oly updated this revision to Diff 28863.Sep 17 2021, 6:31 PM

Third times a charm hopefully.

oly updated this revision to Diff 28874.Sep 19 2021, 6:41 PM

Minor changes from comment in chat mainly adding 00 in front of the perms and reverting the package file

oly added a comment.Sep 19 2021, 6:46 PM

Okay you asked why this is not built from source, this is a little complicated the source does not really need building, ci basically copies these files and adds a jar which is not included in the src repo.
I looked into building this ja from source and injecting but it seems to be a catch 22 in that you need clojure build tools to make the jar but as these do not exist in the repo this seems impractical.
In this situation is it okay to include or would another work around be required ?

JoshStrobl requested changes to this revision.Sep 27 2021, 10:14 PM

Thanks for the clarification. Still need to see the issues I raised (like properly generating the package.yml, I can tell it isn't since the alignment is off). Let's get this set to programming.tools component as well.

This revision now requires changes to proceed.Sep 27 2021, 10:14 PM
oly updated this revision to Diff 29008.Sep 28 2021, 6:16 PM

Generated package.yaml and copied values over, changed to tag as programming.tools

oly added a comment.Oct 16 2021, 6:41 AM

Anything left still blocking this package ? I want to package some other apps but am awaiting the inclusion of this one

oly updated this revision to Diff 29873.Fri, Nov 12, 1:54 PM

Updated to latest clojure version

oly updated this revision to Diff 29998.Fri, Nov 19, 8:37 AM
oly marked 4 inline comments as done.

Added maintainers file remove erroneous 4 and push revision back to 1

oly updated this revision to Diff 29999.Fri, Nov 19, 8:51 AM

Updated pspec file

JoshStrobl accepted this revision.Fri, Nov 19, 8:52 AM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Nov 19, 8:52 AM
JoshStrobl retitled this revision from The inclusion of clojure-tools fixes T9768 to The inclusion of clojure-tools.Fri, Nov 19, 8:52 AM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a task: T9768: Clojure.
This revision was automatically updated to reflect the committed changes.