Page MenuHomeSolus

Changing symbol style from 'sifr' to 'sifr_dark'. Fixes T9627
ClosedPublic

Authored by maikwoehl on Sun, Sep 12, 11:27 PM.

Details

Summary

The default symbol style of libreoffice is a little to dark for the dark theme. So changing it to 'sifr_dark' would improve the initial user experience with libreoffice.

Fixes T9627

Test Plan
  1. Purge libreoffice from dev-machine / Create a solus VM.
  2. Install new packaged eopkg.
  3. Check default symbol style while having (default) dark theme enabled.

Diff Detail

Repository
R1835 libreoffice
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Sun, Sep 12, 11:27 PM

Unfortunately the build fails because of some errors in source code:

[CXX] connectivity/source/commontools/CommonTools.cxx
clang-12: warning: argument unused during compilation: '-feliminate-unused-debug-types' [-Wunused-command-line-argument]
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5484:42: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                ((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                         ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5490:43: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                          ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5500:43: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                {((*yyvalp).pParseNode) = SQL_NEW_COMMALISTRULE;
                                          ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:140:78: note: expanded from macro 'SQL_NEW_COMMALISTRULE'
#define SQL_NEW_COMMALISTRULE   newNode("", SQLNodeType::CommaListRule, yyr1[yyn])
                                                                             ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5510:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5518:71: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                                            {((*yyvalp).pParseNode) = SQL_NEW_LISTRULE;}
                                                                      ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:139:68: note: expanded from macro 'SQL_NEW_LISTRULE'
#define SQL_NEW_LISTRULE                newNode("", SQLNodeType::ListRule, yyr1[yyn])
                                                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5528:29: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        ((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                 ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5535:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5541:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5547:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5553:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5560:30: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                                ((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                         ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5567:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5575:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5581:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5590:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5598:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5609:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5623:51: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                        {((*yyvalp).pParseNode) = SQL_NEW_RULE;
                                                  ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5631:47: error: use of undeclared identifier 'yyn'; did you mean 'yyk'?
                    {((*yyvalp).pParseNode) = SQL_NEW_RULE;}
                                              ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:138:61: note: expanded from macro 'SQL_NEW_RULE'
#define SQL_NEW_RULE                    newNode("", SQLNodeType::Rule, yyr1[yyn])
                                                                            ^
/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:5435:49: note: 'yyk' declared here
              yyGLRStack* yystackp, YYPTRDIFF_T yyk,
                                                ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[1]: *** [/home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/solenv/gbuild/LinkTarget.mk:347: /home/build/YPKG/root/libreoffice/build/libreoffice-7.2.0.4/workdir/GenCxxObject/YaccTarget/connectivity/source/parse/sqlbison.o] Error 1
make[1]: *** Waiting for unfinished jobs....
clang-12: warning: argument unused during compilation: '-feliminate-unused-debug-types' [-Wunused-command-line-argument]
make: *** [Makefile:287: build] Error 2
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildHuFIZ0']' returned non-zero exit status 2
[Build] build failed
ERRO[08:31:47] Failed to build package                       error="exit status 1"
ERRO[08:32:00] Failed to build packages                     
make[1]: Verzeichnis „/home/mwoehl/Nextcloud/dev/software/solus/libreoffice“ wird verlassen
make abireport
make[1]: Verzeichnis „/home/mwoehl/Nextcloud/dev/software/solus/libreoffice“ wird betreten
"../."/common/Go/yabi/yabi *.eopkg
 ⮞  Scanning '*.eopkg'...
 🕱  Failed to open package '*.eopkg', reason: open *.eopkg: no such file or directory
make[1]: *** [../Makefile.common:15: abireport] Fehler 1
make[1]: Verzeichnis „/home/mwoehl/Nextcloud/dev/software/solus/libreoffice“ wird verlassen
make: *** [../Makefile.common:12: complete] Fehler 2
maikwoehl requested review of this revision.Thu, Sep 16, 5:12 PM
maikwoehl edited the test plan for this revision. (Show Details)
maikwoehl added a project: Software.

I had to build it against main profile. Unfortunately the unstable profile does not work. The build issues are included in the previous comment.

JoshStrobl requested changes to this revision.Thu, Sep 16, 5:49 PM
JoshStrobl added a subscriber: JoshStrobl.

It needs to be built against unstable.

This revision now requires changes to proceed.Thu, Sep 16, 5:49 PM

Prodding @joebonrichie since he was the last one to touch libreoffice.

I'm guessing it's failing as bison was recently updated. I'll have a look at updating it to 7.2.1.x and backporting a patch if required.

Needs to be rebased against master

JoshStrobl accepted this revision.Mon, Sep 27, 10:02 PM

LGTM, thanks!

This revision is now accepted and ready to land.Mon, Sep 27, 10:02 PM