Page MenuHomeSolus

The inclusion of python-fabulous will fix T9402
ClosedPublic

Authored by maikwoehl on Sep 12 2021, 4:21 PM.

Details

Summary

fabulous is a dependency for paperwork shell.

Necessary for D11839.

Fix T9402

Test Plan

The upstream dependency paperwork-shell works fine with not-tested package.

Installed and executed fabulous-demo on terminal. It works.

If more testing is required, please write a note.

Diff Detail

Branch
main
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1755
Build 1755: arc lint + arc unit

Event Timeline

maikwoehl created this revision.Sep 12 2021, 4:21 PM
maikwoehl edited the summary of this revision. (Show Details)Sep 12 2021, 4:36 PM
maikwoehl edited the summary of this revision. (Show Details)
maikwoehl edited the summary of this revision. (Show Details)Sep 12 2021, 4:38 PM
maikwoehl updated this revision to Diff 28838.Sep 16 2021, 7:10 PM
maikwoehl edited the summary of this revision. (Show Details)

Adding python3 as rundep

maikwoehl requested review of this revision.Sep 16 2021, 7:10 PM

The term package relies on stdin for testing itself. That cannot work in chroot of solbuild:

https://stackoverflow.com/questions/54012510/pipenv-shell-in-jenkins-return-the-issue-termios-error-25-inappropriate-ioct

Or would it?

The tests of python-fabulous are failing for the same reason.

maikwoehl edited the summary of this revision. (Show Details)Sep 16 2021, 7:22 PM
maikwoehl edited the test plan for this revision. (Show Details)
maikwoehl edited the test plan for this revision. (Show Details)Sep 16 2021, 7:30 PM
maikwoehl updated this revision to Diff 28840.Sep 16 2021, 7:32 PM

Split utils and removed python3 dev env. Works with out-of-the-box binary.

So no rundeps apart from the shipped python3 binaries. Is that right? Or should I include the python3 package anyway?

maikwoehl retitled this revision from The inclusion of python-fabulous will fix T9402 to [RFC] The inclusion of python-fabulous will fix T9402.Sep 16 2021, 7:41 PM
joebonrichie requested changes to this revision.Sep 16 2021, 8:07 PM
joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
package.yml
5

Can you change the source to https://pypi.io/packages/source/f/fabulous/fabulous-0.4.0.tar.gz. This is mostly for readability and to avoid an annoying make bump bug with this particular type of URL.

19

Lines 16-19 not necessary and can be removed. python-setuptools is only required for python2. Setuptools is built into python3.

This revision now requires changes to proceed.Sep 16 2021, 8:07 PM
joebonrichie added inline comments.Sep 16 2021, 8:09 PM
package.yml
14

I don't think a subpackage for utils is required here. It's only an extra 4KB :D

joebonrichie added inline comments.Sep 16 2021, 8:11 PM
package.yml
12

This is a nitpick: but you can merge this line into the main paragraph or remove it all together? You can use homepage : URL as an alternative.

maikwoehl updated this revision to Diff 28849.Sep 17 2021, 4:32 PM

Updating source link

maikwoehl marked 4 inline comments as done.Sep 17 2021, 4:32 PM
joebonrichie requested changes to this revision.Sep 17 2021, 6:53 PM
joebonrichie added inline comments.
package.yml
14

Another nitpick sorry. Can you move homepage to below source. That is the usual location.

This revision now requires changes to proceed.Sep 17 2021, 6:53 PM
maikwoehl updated this revision to Diff 28864.Sep 17 2021, 7:27 PM

Relocate homepage

maikwoehl marked an inline comment as done.Sep 17 2021, 7:27 PM
joebonrichie accepted this revision.Sep 17 2021, 8:22 PM
This revision is now accepted and ready to land.Sep 17 2021, 8:22 PM
maikwoehl retitled this revision from [RFC] The inclusion of python-fabulous will fix T9402 to The inclusion of python-fabulous will fix T9402.Mon, Sep 20, 4:47 PM
This revision was automatically updated to reflect the committed changes.