Page MenuHomeSolus

The inclusion of python-getkey will fix T9402
ClosedPublic

Authored by maikwoehl on Sun, Sep 12, 4:20 PM.

Details

Summary

getkey is a dependency of paperwork-shell

It is build without tests, otherwise it has to introduce new packages
into solus repository.

Necessary for D11839

Test Plan

The upstream dependency paperwork-shell works fine with not-tested package.

Import getkey in python3 interactive shell. Had worked.

If more testing is required, please write a note.

Diff Detail

Repository
R5320 python-getkey
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Sun, Sep 12, 4:20 PM
maikwoehl edited the summary of this revision. (Show Details)Sun, Sep 12, 4:38 PM
maikwoehl requested review of this revision.EditedThu, Sep 16, 6:43 PM

python-coveralls

For python-coveralls we have a problem:

  1. The pip package python-coveralls is buildable without tests. Test dependencies not working as they are too old. -> https://pypi.org/project/python-coveralls
  2. An alternative pip package coveralls-python would need another pip package called responses. -> https://pypi.org/project/coveralls/ and https://pypi.org/project/responses/
  3. As a test dependency we have an old version of python-coverage here. Testing is not possible.
  4. The package python-getkey can build without tests.

Question: Should coveralls be included into repository to test python-getkey?

doublex

doublex can be packaged, but not tested. The pip package does not include the tests and the git repository has no tag for the newest release. But I could directly link to the commit that is related to the release on PIP: https://bitbucket.org/DavidVilla/python-doublex/commits/fe03fcb4672dcf90c0f61f8b56e8df710bc31933

Question: Should I use this commit or should I leave the testing?

Question: Should the test dependencies be included overall?

joebonrichie added a subscriber: joebonrichie.EditedThu, Sep 16, 7:00 PM

Including python modules just so tests pass is not required. Manual testing is sufficient.

maikwoehl updated this revision to Diff 28839.Thu, Sep 16, 7:16 PM

Updated package.yml to remove tests

maikwoehl edited the summary of this revision. (Show Details)Thu, Sep 16, 7:20 PM
maikwoehl edited the test plan for this revision. (Show Details)
maikwoehl updated this revision to Diff 28841.Thu, Sep 16, 7:34 PM

Removed python3 dev env from rundeps

No rundeps required apart from shipped python3 binary

maikwoehl edited the test plan for this revision. (Show Details)Thu, Sep 16, 7:35 PM
maikwoehl retitled this revision from The inclusion of python-getkey will fix T9402 to [RFC] The inclusion of python-getkey will fix T9402.Thu, Sep 16, 7:41 PM
joebonrichie requested changes to this revision.Thu, Sep 16, 8:07 PM
joebonrichie added inline comments.
package.yml
6

Can you change source to https://pypi.io/packages/source/g/getkey/getkey-0.6.5.tar.gz

16

Lines 13-15 not necessary.

This revision now requires changes to proceed.Thu, Sep 16, 8:07 PM
maikwoehl updated this revision to Diff 28848.Fri, Sep 17, 4:29 PM

Fix package.yml according to joebonrichie

maikwoehl marked 2 inline comments as done.Fri, Sep 17, 4:29 PM
joebonrichie accepted this revision.
This revision is now accepted and ready to land.Fri, Sep 17, 6:52 PM
maikwoehl retitled this revision from [RFC] The inclusion of python-getkey will fix T9402 to The inclusion of python-getkey will fix T9402.Mon, Sep 20, 4:47 PM
This revision was automatically updated to reflect the committed changes.