Page MenuHomeSolus

Update atomicparsley to 20210715
ClosedPublic

Authored by algent on Sun, Sep 12, 9:54 AM.

Details

Summary

Changelog:

  • Fixes up NSImage to use a technique that doesn't depend on the DPI of the current screen and just uses pixels
  • Fixes a crash when releasing the image; the crash was caused by a memset call getting a different size for the filename buffer.
  • Replace naughty fgetpos/poke/fsetpos with fseeko
  • fpos_t is intended to be an opaque type so reaching inside it is not right.
  • Switch to fseeko/ftello which are the off_t equivalents of fseek/ftell.
  • Fixed some bogus bitwise operations around supplemental info
  • Fixed a crash when running with -T
  • Increased MAX_ATOMS
  • Add f4v brand
  • Simplified jpeg file recognition and made it hopefully more compatible
  • Add tags for roles in classical music
  • --hdvideo now supports tagging 1080p videos
  • Re-enable buffering for writes; should improve CPU utilization

Packager notes:

  • This project has been moved to github
  • Fix License

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Set some metadata into MPEG-4 files.

Diff Detail

Repository
R3572 atomicparsley
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Sun, Sep 12, 9:54 AM
algent requested review of this revision.Sun, Sep 12, 9:54 AM
algent retitled this revision from Update atomichparsley to 20210715 to Update atomicparsley to 20210715.Sun, Sep 12, 4:59 PM
JoshStrobl accepted this revision.Wed, Sep 15, 3:09 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Sep 15, 3:09 PM
This revision was automatically updated to reflect the committed changes.