Page MenuHomeSolus

Update paperwork-backend to 2.0.3
ClosedPublic

Authored by maikwoehl on Thu, Sep 9, 12:06 AM.

Details

Summary

paperwork-backend has got an update on it's dependencies and build process.

Depends on D11823
Depends on D11822

Fix T9402

Test Plan

Build paperwork-gtk/paperwork-gui and it works.

Diff Detail

Repository
R2296 paperwork-backend
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Thu, Sep 9, 12:06 AM
maikwoehl requested review of this revision.Thu, Sep 9, 12:06 AM
algent added a subscriber: algent.EditedThu, Sep 9, 7:50 PM

source: https://files.pythonhosted.org/packages/source/p/paperwork-backend/paperwork-backend-2.0.3.tar.gz

rundeps    :
    - libpillowfight
    - libinsane
    - openpaperwork-core
    - openpaperwork-gtk
    - poppler
    - python-gobject
    - python-levenshtein
    - python-psutil
    - python-pycountry
    - python-pyocr
    - python-simplebayes
    - python-whoosh
    - python3-cairo
build      : |
    %python3_setup
install    : |
    %python3_install
maikwoehl updated this revision to Diff 28748.Thu, Sep 9, 8:25 PM

Use pip package for building

algent added a comment.Thu, Sep 9, 8:35 PM

Hey Maik, I don't think you need:
python3-cairo-devel
python-distro - this for sure because it is rundep of openpaperwork-core.
python-wheel

Also it is good to order rundeps "0 to 9", "A to Z" and "a to z".

maikwoehl updated this revision to Diff 28749.Thu, Sep 9, 8:45 PM

Remove unnecessary dependencies and reorder them

Hey Maik, I don't think you need:
python3-cairo-devel
python-distro - this for sure because it is rundep of openpaperwork-core.
python-wheel
Also it is good to order rundeps "0 to 9", "A to Z" and "a to z".

Thank you :)

algent added a comment.Thu, Sep 9, 9:00 PM

You should not remove rundeps.
They are same as builddeps and these builddeps are required only for testing.

You should not remove rundeps.
They are same as builddeps and these builddeps are required only for testing.

What exactly do you mean? I thought as the packages are needed to build and test the package they will automatically become runtime dependencies? Or did I missed something in the documentation? Maybe you mean that the deps should be semantically in rundeps?

maikwoehl updated this revision to Diff 28750.Thu, Sep 9, 9:51 PM

Duplicated the dependencies to show up in eopkg info.

psutil is only used for testing.

The other are required for testing and at runtime.

maikwoehl edited the summary of this revision. (Show Details)Fri, Sep 10, 12:14 AM
maikwoehl retitled this revision from Update paperwork-backend to 2.0.3 to [RFC] Update paperwork-backend to 2.0.3.Fri, Sep 10, 1:29 AM

What exactly do you mean? I thought as the packages are needed to build and test the package they will automatically become runtime dependencies? Or did I missed something in the documentation? Maybe you mean that the deps should be semantically in rundeps?

That is not always true, expecially for python packages.
There are no abi_used_libs reported, so there are no packages automatically aded as rundeps.

Same source nitpick here

maikwoehl updated this revision to Diff 28852.Fri, Sep 17, 4:47 PM

Update source link

maikwoehl updated this revision to Diff 28856.Fri, Sep 17, 4:56 PM

Add MAINTAINERS.md

joebonrichie requested changes to this revision.Fri, Sep 17, 6:59 PM
joebonrichie added inline comments.
package.yml
12–13

Can you sort builddeps and rundeps alphabetically. 0-9A-Za-z

This revision now requires changes to proceed.Fri, Sep 17, 6:59 PM
maikwoehl marked an inline comment as done.Fri, Sep 17, 7:29 PM
maikwoehl updated this revision to Diff 28866.Fri, Sep 17, 7:32 PM

Reorder dependencies

is python3 now below python- or before?

is python3 now below python- or before?

Now it is fine. python3 is after python-

is python3 now below python- or before?

Now it is fine. python3 is after python-

Okay, thank you :)

joebonrichie accepted this revision.Sat, Sep 18, 11:54 AM
This revision is now accepted and ready to land.Sat, Sep 18, 11:54 AM
maikwoehl retitled this revision from [RFC] Update paperwork-backend to 2.0.3 to Update paperwork-backend to 2.0.3.Mon, Sep 20, 4:47 PM
This revision was automatically updated to reflect the committed changes.