Page MenuHomeSolus

The inclusion of openpaperwork-core will fix T9402
ClosedPublic

Authored by maikwoehl on Thu, Sep 9, 12:03 AM.

Details

Summary

The openpaperwork-core consists of shared file across the paperwork application part.

Test Plan

Build paperwork-backend and paperwork-gtk and it works.

Diff Detail

Repository
R5323 openpaperwork-core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maikwoehl created this revision.Thu, Sep 9, 12:03 AM
maikwoehl requested review of this revision.Thu, Sep 9, 12:03 AM
algent added a subscriber: algent.Thu, Sep 9, 5:09 PM

In my opinion it is better to use PYPI tarball for this package.
https://files.pythonhosted.org/packages/source/o/openpaperwork-core/openpaperwork-core-2.0.3.tar.gz

And then you can build this package like this:

builddeps  :
    - python-distro
rundeps    :
    - python-distro
build      : |
    %python3_setup
install    : |
    %python3_install
check      : |
    %python3_test

From pspec_x86_64.xml the version is compiled wrong:
<Path fileType="library">/usr/lib/python3.9/site-packages/openpaperwork_core-0.0.0-py3.9.egg-info/PKG-INFO</Path>
Building from pypi it is openpaperwork_core-2.0.3-py3.9.egg-info

Same thing you can do with other packages:
openpaperwork-gtk and paperwork-backend

In my opinion it is better to use PYPI tarball for this package.
https://files.pythonhosted.org/packages/source/o/openpaperwork-core/openpaperwork-core-2.0.3.tar.gz
And then you can build this package like this:

builddeps  :
    - python-distro
rundeps    :
    - python-distro
build      : |
    %python3_setup
install    : |
    %python3_install
check      : |
    %python3_test

From pspec_x86_64.xml the version is compiled wrong:
<Path fileType="library">/usr/lib/python3.9/site-packages/openpaperwork_core-0.0.0-py3.9.egg-info/PKG-INFO</Path>
Building from pypi it is openpaperwork_core-2.0.3-py3.9.egg-info
Same thing you can do with other packages:
openpaperwork-gtk and paperwork-backend

Good point, @algent - I will try that for all packages.

maikwoehl updated this revision to Diff 28746.Thu, Sep 9, 6:58 PM

Using the way proposed by algent

maikwoehl edited the summary of this revision. (Show Details)Fri, Sep 10, 12:16 AM
maikwoehl retitled this revision from The inclusion of openpaperwork-core will fix T9402 to [RFC] The inclusion of openpaperwork-core will fix T9402.Fri, Sep 10, 1:29 AM
joebonrichie requested changes to this revision.Thu, Sep 16, 8:23 PM
joebonrichie added a subscriber: joebonrichie.

Source nitpick

package.yml
6

https://pypi.io/packages/source/o/openpaperwork-core/openpaperwork-core-2.0.3.tar.gz or gitlab source please ^^

This revision now requires changes to proceed.Thu, Sep 16, 8:23 PM
maikwoehl updated this revision to Diff 28850.Fri, Sep 17, 4:35 PM
maikwoehl edited the summary of this revision. (Show Details)

Change source link

maikwoehl marked an inline comment as done.Fri, Sep 17, 4:37 PM
maikwoehl updated this revision to Diff 28854.Fri, Sep 17, 4:56 PM

Add MAINTAINERS.md

joebonrichie accepted this revision.Fri, Sep 17, 6:54 PM
This revision is now accepted and ready to land.Fri, Sep 17, 6:54 PM
maikwoehl retitled this revision from [RFC] The inclusion of openpaperwork-core will fix T9402 to The inclusion of openpaperwork-core will fix T9402.Mon, Sep 20, 4:47 PM
This revision was automatically updated to reflect the committed changes.