Page MenuHomeSolus

Update spdlog from 1.5.0 to 1.9.2
AcceptedPublic

Authored by h3o on Sat, Sep 4, 8:25 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T9691: Package Request: Waybar
Summary

Update spdlog from 1.5.0 to 1.9.2
Update needed to resolve T9691

No historical changelog provided by upstream. Release note for 1.9.2 are here.

Test Plan

Successfully built against waybar in local repository

Diff Detail

Repository
R4909 spdlog
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1676
Build 1676: arc lint + arc unit

Event Timeline

h3o created this revision.Sat, Sep 4, 8:25 PM
h3o requested review of this revision.Sat, Sep 4, 8:25 PM
h3o edited the summary of this revision. (Show Details)Sat, Sep 4, 8:26 PM
h3o edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Mon, Sep 6, 11:08 AM
JoshStrobl added a subscriber: JoshStrobl.

Please use Markdown in your changelogs. URLs should be formatted as [string](url)

You also need to clone and use the existing repo.

This revision now requires changes to proceed.Mon, Sep 6, 11:08 AM
h3o edited the summary of this revision. (Show Details)Mon, Sep 6, 3:06 PM
h3o updated this revision to Diff 28726.Mon, Sep 6, 3:07 PM
h3o edited the summary of this revision. (Show Details)

Re-submitting patch as local repository was missing from previous submission.

h3o edited the summary of this revision. (Show Details)Mon, Sep 6, 3:08 PM

Please use Markdown in your changelogs. URLs should be formatted as [string](url)
You also need to clone and use the existing repo.

Weird, not sure how the repo info was missing before? Hope all is good now.

h3o updated this revision to Diff 28731.Mon, Sep 6, 4:52 PM
h3o edited the summary of this revision. (Show Details)

Updated link in summary.

JoshStrobl accepted this revision.Wed, Sep 15, 4:32 PM

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Sep 15, 4:32 PM
JoshStrobl edited the summary of this revision. (Show Details)Wed, Sep 15, 4:32 PM