Page MenuHomeSolus

Update libopenmpt to 0.5.11
ClosedPublic

Authored by aleksvor on Sat, Sep 4, 9:53 AM.

Details

Summary

Changelog:

  • Security fixes:
    • Possible crash with malformed modules when trying to access non-existent plugin slots FX251-FX255.
    • Possible read beyond sample start after swapping to a sample with loop points set but not loop enabled.
    • Fixed various possible crashes with malformed MMCMP files.
    • MED: Possible read past end of sequence name (stack-allocated, so relatively unlikely to result in a crash).
  • Fixed excessive memory usage with files claiming to have an extremely high rows per beat count while also using tempo swing. Maximum rows per beat are now limited to 65536.
  • STP: Avoid creating thousands of patterns when loading malformed files even though no more pattern data can be read.
Test Plan

Played some tracked music files in mpv and Audacious.

Diff Detail

Repository
R5203 libopenmpt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Sat, Sep 4, 9:53 AM
aleksvor requested review of this revision.Sat, Sep 4, 9:53 AM
JoshStrobl accepted this revision.Mon, Sep 6, 10:29 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Mon, Sep 6, 10:29 AM
This revision was automatically updated to reflect the committed changes.