Page MenuHomeSolus

Update fmt to 8.0.1
AcceptedPublic

Authored by h3o on Wed, Sep 1, 6:47 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T9691: Package Request: Waybar
Summary

Update to 8.0.1. Changelog available here.

Test Plan

Successfully built waybar with this package

Diff Detail

Repository
R4591 fmt
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1677
Build 1677: arc lint + arc unit

Event Timeline

h3o created this revision.Wed, Sep 1, 6:47 PM
h3o requested review of this revision.Wed, Sep 1, 6:47 PM
h3o added a comment.Wed, Sep 1, 6:48 PM

This package update is required to build waybar. There are a few others I will need to submit but will wait to see if anything I need to be doing differently before proceeding with any other submissions. Thanks!

h3o edited the summary of this revision. (Show Details)Wed, Sep 1, 9:02 PM
h3o edited the test plan for this revision. (Show Details)
algent added a subscriber: algent.Wed, Sep 1, 9:24 PM

I think you should use this changelog link, because the update is not from version 8.0.0 to 8.0.1 but from version 6.2.1 to 8.0.1.

h3o edited the summary of this revision. (Show Details)Wed, Sep 1, 9:51 PM

I think you should use this changelog link, because the update is not from version 8.0.0 to 8.0.1 but from version 6.2.1 to 8.0.1.

Thanks, done!

I think this link to the changelog is even more accurate, has the advantage to use both the permalink to the version and the tag when it was redacted.

JoshStrobl requested changes to this revision.Thu, Sep 2, 2:58 PM
JoshStrobl added a subscriber: JoshStrobl.

I appreciate the patch however won't be pulling this in until I see the full waybar stack. I provided you the documentation in another commit on building with a local repo, as well as instructions on how to set the child / parent revisions, so please use those to your advantage to communicate the other patches as part of waybar when submitting that patch. Thanks.

This revision now requires changes to proceed.Thu, Sep 2, 2:58 PM
h3o edited the summary of this revision. (Show Details)Sat, Sep 4, 8:28 PM
h3o updated this revision to Diff 28732.Mon, Sep 6, 4:57 PM
h3o edited the summary of this revision. (Show Details)
h3o edited the test plan for this revision. (Show Details)
h3o removed a reviewer: JoshStrobl.

Revised link in summary

JoshStrobl accepted this revision.Wed, Sep 15, 4:33 PM
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Sep 15, 4:33 PM