Page MenuHomeSolus

Update fmt to 8.0.1
ClosedPublic

Authored by h3o on Sep 1 2021, 6:47 PM.
Tags
None
Referenced Files
F10983224: D11784.diff
Sun, Jul 23, 1:31 PM
F10982423: D11784.diff
Sun, Jul 23, 10:26 AM
F10845534: D11784.id28633.diff
Jun 11 2023, 12:49 AM
F10841149: D11784.id28732.diff
Jun 10 2023, 4:44 AM
F10840769: D11784.id29121.diff
Jun 10 2023, 3:08 AM
F10836501: D11784.diff
Jun 8 2023, 5:39 PM
F10786307: D11784.id28633.diff
May 26 2023, 7:28 AM
F10784327: D11784.id28732.diff
May 26 2023, 12:15 AM

Details

Summary

Update to 8.0.1. Changelog available here.

Test Plan

Successfully built waybar with this package

Diff Detail

Repository
R4591 fmt
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

h3o requested review of this revision.Sep 1 2021, 6:47 PM

This package update is required to build waybar. There are a few others I will need to submit but will wait to see if anything I need to be doing differently before proceeding with any other submissions. Thanks!

h3o edited the test plan for this revision. (Show Details)

I think you should use this changelog link, because the update is not from version 8.0.0 to 8.0.1 but from version 6.2.1 to 8.0.1.

I think you should use this changelog link, because the update is not from version 8.0.0 to 8.0.1 but from version 6.2.1 to 8.0.1.

Thanks, done!

I think this link to the changelog is even more accurate, has the advantage to use both the permalink to the version and the tag when it was redacted.

JoshStrobl added a subscriber: JoshStrobl.

I appreciate the patch however won't be pulling this in until I see the full waybar stack. I provided you the documentation in another commit on building with a local repo, as well as instructions on how to set the child / parent revisions, so please use those to your advantage to communicate the other patches as part of waybar when submitting that patch. Thanks.

This revision now requires changes to proceed.Sep 2 2021, 2:58 PM
h3o edited the summary of this revision. (Show Details)
h3o edited the test plan for this revision. (Show Details)
h3o removed a reviewer: JoshStrobl.

Revised link in summary

JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Sep 15 2021, 4:33 PM
This revision was automatically updated to reflect the committed changes.