Page MenuHomeSolus

Initial commit of chrono-date
AcceptedPublic

Authored by h3o on Wed, Sep 1, 6:34 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Initial commit of chrono-date (dependency for waybar)

Package inclusion needed to support T9691

Test Plan

Successfully built against waybar in local repository

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1670
Build 1670: arc lint + arc unit

Event Timeline

h3o created this revision.Wed, Sep 1, 6:34 PM
h3o requested review of this revision.Wed, Sep 1, 6:34 PM
h3o added a comment.Wed, Sep 1, 6:37 PM

This is a follow up to an abandoned submission here: https://dev.getsol.us/D11360
chrono-date is required to build waybar, as mentioned here: https://dev.getsol.us/T9691

This is the first time I've packaged something, please let me know if anything should have been done differently. Thanks!

JoshStrobl requested changes to this revision.Thu, Sep 2, 12:25 PM
JoshStrobl added a subscriber: JoshStrobl.

Good start! Please provide the patch for waybar as well. You do not need to wait for this to be included in the repository in order to package it, you can follow https://getsol.us/articles/packaging/local-repository/en/

You can use the child / parent revision functionality to have waybar depend on this patch, so this patch gets reviewed and landed first. Alternatively you can do Depends on D11783 in the summary.

Lastly, please provider a file called MAINTAINERS.md that has the following contents, replacing the applicable parts:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- NAME
  - IRC: REPLACE_ME
  - Email: REPLACE_ME
package.yml
9

Let's replace <chrono> with just chrono

11

Let's replace <chrono> with just chrono

pspec_x86_64.xml
17

All of this should be pattered into the main package as it is a devel only library, there's no linking involved, etc.

So should be:

patterns:
    - /*
This revision now requires changes to proceed.Thu, Sep 2, 12:25 PM
h3o updated this revision to Diff 28672.Thu, Sep 2, 9:44 PM

Initial commit of chrono-date

h3o marked 2 inline comments as done.Thu, Sep 2, 10:08 PM

I tried adding this through git/arc but getting a bit lost there.. can you accept the MAINTAINERS.md file from here?

pspec_x86_64.xml
17

Not sure I understood this correctly, but I've added that line to package.yml

Try git add MAINTAINERS.md, git commit --amend as normal then arc diff --edit to upload the updated patch to phabricator. Let me know if that helps

h3o added a comment.Thu, Sep 2, 11:06 PM

Try git add MAINTAINERS.md, git commit --amend as normal then arc diff --edit to upload the updated patch to phabricator. Let me know if that helps

first two steps seemed to work, and I can see in the git log the MAINTAINERS.md file has been added. No luck with 'arc diff --edit' though.

"Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
Usage Exception: No changes found. (Did you specify the wrong commit range?)"

algent added a subscriber: algent.Fri, Sep 3, 3:45 AM

No luck with 'arc diff --edit' though.

Just run arc diff without --edit flag. A new promt will ask you for a commit message, and in this case you can write Add MAINTAINERS.md file.
arc diff --edit is used when you are going to update this patch message, in this case it is Initial commit of chrono-date. This is necessary if you had any typos there and you want to edit that commit message for command line.

h3o added a comment.EditedFri, Sep 3, 4:05 AM

No luck with 'arc diff --edit' though.

Just run arc diff without --edit flag. A new promt will ask you for a commit message, and in this case you can write Add MAINTAINERS.md file.
arc diff --edit is used when you are going to update this patch message, in this case it is Initial commit of chrono-date. This is necessary if you had any typos there and you want to edit that commit message for command line.

Appreciate all the help. Unfortunately, I get same error as above when using just 'arc diff' too. This might be overkill, but maybe easier if I just re-submit from scratch?

algent added a comment.EditedFri, Sep 3, 4:08 AM

This might be overkill, but maybe easier if I just re-submit from scratch

NO.
make clean To make sure that there aren't any eopkg file in the folder.
git add *
git commit --amend
arc diff --update D11783 To make sure that you are updating this diff.

h3o updated this revision to Diff 28676.Fri, Sep 3, 4:26 AM

Add MAINTAINERS.md

h3o added a comment.EditedFri, Sep 3, 4:29 AM

This might be overkill, but maybe easier if I just re-submit from scratch

NO.
make clean To make sure that there aren't any eopkg file in the folder.
git add *
git commit --amend
arc diff --update D11783 To make sure that you are updating this diff.

smh, MAINTAINERS.md added, other files removed? In a way, I feel that's progress.

Edit: are you able to see/use the other files in 'History', or do they all need to be updated under the same Diff? Gotta get to call it a night but will work more on this tomorrow. Thanks for the help and patience everyone!

algent added a comment.Fri, Sep 3, 7:23 AM

Yes it is strange that the other files are removed.
Are the other files, Makefile package.yml and pspec_x86_64.xml in the same directory with MAINTAINERS.md ?

JoshStrobl requested changes to this revision.Fri, Sep 3, 10:16 AM
This revision now requires changes to proceed.Fri, Sep 3, 10:16 AM
h3o updated this revision to Diff 28696.Sat, Sep 4, 1:02 AM
h3o marked an inline comment as done.

Updating initial commit of chrono-date

h3o edited the summary of this revision. (Show Details)Sat, Sep 4, 8:29 PM
h3o edited the test plan for this revision. (Show Details)
JoshStrobl requested changes to this revision.Mon, Sep 6, 11:18 AM
JoshStrobl added inline comments.
MAINTAINERS.md
4

While I am not 100% certain, I am pretty sure (h3o) is not your name.

Adding your Phabricator name is not necessary, we know from the commit history.

This revision now requires changes to proceed.Mon, Sep 6, 11:18 AM
h3o updated this revision to Diff 28725.Mon, Sep 6, 2:47 PM

Revised MAINTAINERS.md

h3o marked an inline comment as done.Mon, Sep 6, 2:49 PM

Revised MAINTAINER.md and LOL at "pretty sure h3o is not your name" : )

JoshStrobl accepted this revision.Wed, Sep 15, 4:34 PM

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Sep 15, 4:34 PM