Page MenuHomeSolus

Add python-orjson dependency to anki
ClosedPublic

Authored by Staudey on Aug 17 2021, 5:14 PM.

Details

Summary

Add python-orjson dependency to anki

Optional but recommended dependency, which can now finally be built with Rust stable

Depends on D10852

Completely fixes T9597

Test Plan

Played through a few dozen cards of a Japanese deck, pip3 check no longer complains about missing dependencies

Diff Detail

Repository
R4607 anki
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Aug 17 2021, 5:14 PM
Staudey requested review of this revision.Aug 17 2021, 5:14 PM
Staudey edited the test plan for this revision. (Show Details)Aug 17 2021, 5:14 PM
Staudey edited the test plan for this revision. (Show Details)
JoshStrobl accepted this revision.Aug 20 2021, 11:19 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 20 2021, 11:19 AM
JoshStrobl requested changes to this revision.Aug 20 2021, 11:20 AM

Dep isn't in repo, please add to stack.

This revision now requires changes to proceed.Aug 20 2021, 11:20 AM
Staudey requested review of this revision.Aug 20 2021, 2:37 PM
Staudey edited the summary of this revision. (Show Details)

Dep isn't in repo, please add to stack.

Terribly sorry about this! Seems I completely forgot to add it.

JoshStrobl accepted this revision.Aug 22 2021, 11:47 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 22 2021, 11:47 AM
This revision was automatically updated to reflect the committed changes.