Page MenuHomeSolus

python-cryptography: Update to 3.4.7

Authored by ReillyBrogan on Aug 16 2021, 4:55 PM.



Changelog available here

Depends on D11657
Depends on D11663
Depends on D11664
Depends on D11665

Test Plan


  • python-axolotl
  • yubikey-manager
  • python-secretstorage
  • python-oauthlib (tests ran successfully)
  • python-fido2
  • python-openssl (tests ran unsuccessfully, however the same number of tests failed as failed with 3.3.2)
  • Ran all tests and verified that they were successful

Diff Detail

R2569 python-cryptography
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.Aug 16 2021, 4:55 PM
ReillyBrogan requested review of this revision.Aug 16 2021, 4:55 PM

I've unblocked removing python2 support from this package hang tight.

  • Remove python 2 support, cleanup deps
ReillyBrogan edited the summary of this revision. (Show Details)Aug 16 2021, 7:25 PM
ReillyBrogan planned changes to this revision.Aug 16 2021, 7:34 PM
  • Re-enable check phase
joebonrichie accepted this revision.Aug 18 2021, 9:14 AM

Not a huge fan of landing python modules just so the testsuite can pass. On the other hand, it is an interpreted language and they can be helpful for determining compatibility so I will let it pass. LGTM.

This revision is now accepted and ready to land.Aug 18 2021, 9:14 AM
JoshStrobl requested changes to this revision.Aug 25 2021, 3:57 PM
JoshStrobl added a subscriber: JoshStrobl.

Not seeing complete coverage of all the revdeps in the test plan. How was this tested excluding just rebuilds, which does not present runtime errors?

This revision now requires changes to proceed.Aug 25 2021, 3:57 PM
joebonrichie accepted this revision.Aug 28 2021, 1:20 PM

Went through the revdeps myself as I was eager to land this. Despite use of rust the public facing api hasn't really changed.

This revision was not accepted when it landed; it landed in state Needs Revision.Aug 28 2021, 1:22 PM
This revision was automatically updated to reflect the committed changes.